Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning memory leak in Slider component #324

Closed
roberta-racco opened this issue Nov 13, 2020 · 5 comments
Closed

Warning memory leak in Slider component #324

roberta-racco opened this issue Nov 13, 2020 · 5 comments
Assignees
@Utzel-Butzel

Comments

@roberta-racco
Copy link

I have a Slider component inside a Field form.

If i write the Slider like this:

<Slider
  fullWidth
  id={`slider-id`}
  name={`slider-name`}
  min={0}
  max={100} 
  minLabel="%"
  maxLabel="%"
  disabled={!checkValue}
  value={value}
  onChange={(e) => console.log(e)}
/>

I receive this warning in console
Screenshot 2020-11-13 at 11 37 37
@Utzel-Butzel
Copy link
Collaborator

@roberta-racco We'll rewrite the component using functional components and hooks, this should also solve this issue.

Utzel-Butzel added a commit that referenced this issue Nov 23, 2020
@Utzel-Butzel
fix(Slider): rewrite Slider component as functional component and usi…
e9f6e09 
…ng native slider input (#324)
Utzel-Butzel pushed a commit that referenced this issue Nov 23, 2020
@semantic-release-bot
chore(release): 1.10.9 [skip ci]
9b241c8 
## [1.10.9](v1.10.8...v1.10.9) (2020-11-23)

### Bug Fixes

* **Colors:** fixed color keys missing from colors json file ([ae31d32](ae31d32))
* **DatePicker:** resolving react-hook-form datepicker issue ([4dbca46](4dbca46))
* **Export:** export for TableSorting fixed ([dcd3d37](dcd3d37))
* **Loading:** now background color is provided via native css variable ([#327](#327)) ([48eadcf](48eadcf))
* **Notification:** exported notification components ([fdca4c3](fdca4c3))
* **Notifiication:** export was not added ([#326](#326)) ([9db0352](9db0352))
* **NumberInput:** propType for invalid was wrong ([#322](#322)) ([a8f079b](a8f079b))
* **Readmore:** added scrolling to div and improved readme ([#50864](https://github.com/WFP/UI/issues/50864), [#50846](https://github.com/WFP/UI/issues/50846)) ([33fecf7](33fecf7))
* **Slider:** rewrite Slider component as functional component and using native slider input ([#324](#324)) ([e9f6e09](e9f6e09))
* **Table:** added Table to export ([#325](#325)) ([42e9ad6](42e9ad6))
* **Tooltip:** rewrote Tooltip component ([#50816](https://github.com/WFP/UI/issues/50816), [#50817](https://github.com/WFP/UI/issues/50817)) ([40a31d9](40a31d9))
@Utzel-Butzel
Copy link
Collaborator

@roberta-racco Can you please try with 1.10.9 on next if it fits your needs?

@Utzel-Butzel Utzel-Butzel self-assigned this Nov 23, 2020
@roberta-racco
Copy link
Author

Hi @Utzel-Butzel
I installed the new version but the application could not be compiled because of these new errors
Screenshot 2020-11-24 at 12 25 38

Utzel-Butzel added a commit that referenced this issue Nov 24, 2020
@Utzel-Butzel
fix(Notification): not existing icon removed (#324)
d7ec782
Utzel-Butzel pushed a commit that referenced this issue Nov 24, 2020
@semantic-release-bot
chore(release): 1.10.10 [skip ci]
f041b8f 
## [1.10.10](v1.10.9...v1.10.10) (2020-11-24)

### Bug Fixes

* **colors:** added colors to export again ([6c431e6](6c431e6))
* **Notification:** not existing icon removed ([#324](#324)) ([d7ec782](d7ec782))
@Utzel-Butzel
Copy link
Collaborator

Utzel-Butzel commented Nov 24, 2020 •
edited
Loading

Hi @roberta-racco Can you please check with 1.10.11?

@roberta-racco
Copy link
Author

roberta-racco commented Nov 25, 2020 •
edited
Loading

Hi @Utzel-Butzel in the v1.10.12 that specific warning no longer occurs but there are 3 more.
I opened a new issue for those #349, so you can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Utzel-Butzel Utzel-Butzel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Utzel-Butzel @roberta-racco