Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withOverlay prop ignored in Loading component #327

Closed
roberta-racco opened this issue Nov 13, 2020 · 0 comments
Closed

withOverlay prop ignored in Loading component #327

roberta-racco opened this issue Nov 13, 2020 · 0 comments

Comments

@roberta-racco
Copy link

If I pass the withOverlay property in Loading component I expect to see an overlay similar to this:

Screenshot 2020-11-13 at 16 50 52

But instead I don't see an overlay:

Screenshot 2020-11-13 at 16 50 37

Utzel-Butzel added a commit that referenced this issue Nov 16, 2020
…omponent-updates

* origin/feat/1.10.x-improvements:
  fix(NumberInput): propType for invalid was wrong (#322)
  fix(Loading): now background color is provided via native css variable (#327)
  fix(Notifiication): export was not added (#326)
  fix(Table): added Table to export (#325)

# Conflicts:
#	src/components/Input/Input.js
Utzel-Butzel pushed a commit that referenced this issue Nov 23, 2020
## [1.10.9](v1.10.8...v1.10.9) (2020-11-23)

### Bug Fixes

* **Colors:** fixed color keys missing from colors json file ([ae31d32](ae31d32))
* **DatePicker:** resolving react-hook-form datepicker issue ([4dbca46](4dbca46))
* **Export:** export for TableSorting fixed ([dcd3d37](dcd3d37))
* **Loading:** now background color is provided via native css variable ([#327](#327)) ([48eadcf](48eadcf))
* **Notification:** exported notification components ([fdca4c3](fdca4c3))
* **Notifiication:** export was not added ([#326](#326)) ([9db0352](9db0352))
* **NumberInput:** propType for invalid was wrong ([#322](#322)) ([a8f079b](a8f079b))
* **Readmore:** added scrolling to div and improved readme ([#50864](https://github.com/WFP/UI/issues/50864), [#50846](https://github.com/WFP/UI/issues/50846)) ([33fecf7](33fecf7))
* **Slider:** rewrite Slider component as functional component and using native slider input ([#324](#324)) ([e9f6e09](e9f6e09))
* **Table:** added Table to export ([#325](#325)) ([42e9ad6](42e9ad6))
* **Tooltip:** rewrote Tooltip component ([#50816](https://github.com/WFP/UI/issues/50816), [#50817](https://github.com/WFP/UI/issues/50817)) ([40a31d9](40a31d9))
Utzel-Butzel added a commit that referenced this issue Nov 24, 2020
…into feat/1.11.x-improvements

* 'feat/1.11.x-improvements' of https://github.com/wfp/ui:
  Update azure-pipelines.yml for Azure Pipelines
  fix(DatePicker): resolving react-hook-form datepicker issue
  docs(Components): wizard custom sourcecode added, react-hook-form datepicker example added and modal reverted to previous design
  chore(release): 1.10.8 [skip ci]
  fix(Export): export for TableSorting fixed
  docs(StorybookPreview): set width to 100percent and reduced padding left and right
  fix(Colors): fixed color keys missing from colors json file
  docs(WizardForm): ported wizardform to new environment
  fix(Notification): exported notification components
  doc(Components): tested and provided valid codes to replace generated ones and fixed few issues
  docs(NumberInput): removed readme section help us improve
  fix(NumberInput): propType for invalid was wrong (#322)
  fix(Loading): now background color is provided via native css variable (#327)
  fix(Notifiication): export was not added (#326)
  fix(Table): added Table to export (#325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants