Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to retrieve text value in Search component onChange #368

Closed
Girbons opened this issue Dec 23, 2020 · 1 comment
Closed

Unable to retrieve text value in Search component onChange #368

Girbons opened this issue Dec 23, 2020 · 1 comment
Assignees
@Utzel-Butzel

Comments

@Girbons
Copy link

Girbons commented Dec 23, 2020 •
edited
Loading

Detailed description

Accessing Search component value through onChange prop returns NaN when using text due to this https://github.com/wfp/ui/blob/master/src/components/Search/Search.js#L48.

Is this issue related to a specific component?

Search component

What version of the WFP UI (Carbon Design System) are you using?

v1.11.0
@Utzel-Butzel Utzel-Butzel self-assigned this Jan 4, 2021
Utzel-Butzel added a commit that referenced this issue Jan 4, 2021
@Utzel-Butzel
fix(Search): onChange was returning a wrong target value (#368)
6a779e2
Utzel-Butzel added a commit that referenced this issue Jan 4, 2021
@Utzel-Butzel
Merge pull request #369 from wfp/feat/robert-1.12
3509052 
fix(Search): onChange was returning a wrong target value (#368)
Utzel-Butzel pushed a commit that referenced this issue Jan 4, 2021
@semantic-release-bot
chore(release): 1.11.1 [skip ci]
cd343a4 
## [1.11.1](v1.11.0...v1.11.1) (2021-01-04)

### Bug Fixes

* **Form:** reverted top padding spacing to previous on error message in Form component ([81d1243](81d1243))
* **package:** lock file updated ([a9966cc](a9966cc))
* **ReactSelect:** reduced top margin of dropdown to hide required error message ([5d06c84](5d06c84))
* **Search:** onChange was returning a wrong target value ([#368](#368)) ([6a779e2](6a779e2))
@Utzel-Butzel
Copy link
Collaborator

Utzel-Butzel commented Jan 4, 2021 •
edited
Loading

Fixed in https://www.npmjs.com/package/@wfp/ui/v/1.11.3 (next tag) Thanks for pointing out! :)

Utzel-Butzel added a commit that referenced this issue Jan 4, 2021
@Utzel-Butzel
fix(Search): onChange was returning a wrong target value (#368)
d422086
Utzel-Butzel added a commit that referenced this issue Jan 4, 2021
@Utzel-Butzel
Merge pull request #372 from wfp/feat/1.12-improvements-robert
e345267 
fix(Search): onChange was returning a wrong target value (#368)
Utzel-Butzel pushed a commit that referenced this issue Jan 4, 2021
@semantic-release-bot
chore(release): 1.11.0 [skip ci]
7b9bbd1 
# [1.11.0](v1.10.20...v1.11.0) (2021-01-04)

### Bug Fixes

* **Search:** onChange was returning a wrong target value ([#368](#368)) ([d422086](d422086))

### Features

* **package:** trigger release ([cbabcd3](cbabcd3))
Utzel-Butzel pushed a commit that referenced this issue Jan 4, 2021
@semantic-release-bot
chore(release): 1.11.0 [skip ci]
df09849 
# [1.11.0](v1.10.20...v1.11.0) (2021-01-04)

### Bug Fixes

* **Search:** onChange was returning a wrong target value ([#368](#368)) ([d422086](d422086))

### Features

* **package:** trigger release ([cbabcd3](cbabcd3))
Utzel-Butzel pushed a commit that referenced this issue Jan 4, 2021
@semantic-release-bot
chore(release): 1.11.0 [skip ci]
0ec10aa 
# [1.11.0](v1.10.20...v1.11.0) (2021-01-04)

### Bug Fixes

* **package:** manual version bump ([c1b0185](c1b0185))
* **Search:** onChange was returning a wrong target value ([#368](#368)) ([d422086](d422086))

### Features

* **package:** trigger release ([cbabcd3](cbabcd3))
Utzel-Butzel added a commit that referenced this issue Jan 11, 2021
@Utzel-Butzel
Merge remote-tracking branch 'origin/next' into thedevelobear-patch-2
9b13218 
* origin/next:
  chore(release): 1.11.4 [skip ci]
  fix(Slider): fullWidth prop works now (#375), Footer accepts custom components for Logos
  chore(release): 1.11.3 [skip ci]
  fix(package): description changed
  chore(release): 1.11.0 [skip ci]
  fix(package): manual version bump
  chore(release): 1.11.0 [skip ci]
  chore(release): 1.11.0 [skip ci]
  fix(Search): onChange was returning a wrong target value (#368)
  chore(release): 1.11.0 [skip ci]

# Conflicts:
#	CHANGELOG.md
#	package-lock.json
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Utzel-Butzel Utzel-Butzel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Utzel-Butzel @Girbons