Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Set up PR Preview and Travis deploy to gh-pages #60

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 7, 2018

PR Preview documentation:
https://github.com/tobie/pr-preview#configuration-file

Travis setup based on setup in https://github.com/w3c/speech-api.

@foolip
Copy link
Member Author

foolip commented Aug 7, 2018

@atotic I set this up after noticing that #56 still isn't reflected in https://wicg.github.io/ResizeObserver/. There's also a bit of Travis-side setup you need to do, I can guide you on chat if you haven't done it before.

@foolip
Copy link
Member Author

foolip commented Aug 7, 2018

@lukebjerring FYI, if you still see the semicolon missing in reffy-reports, this is what would fix it.

Copy link
Collaborator

@atotic atotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Would love to get some instructions on how am I supposed to use this. I usually run bikeshed locally, and upload changes manually. Making this automatic would be useful.

@foolip
Copy link
Member Author

foolip commented Aug 7, 2018

What will happen is that on every push to master, a VM (on Travis) will be booted up and run the steps in .travis.yml, bikeshed spec being the most interesting step. The result (index.html) will be committed and pushed to the gh-pages branch, facilitated by https://docs.travis-ci.com/user/deployment/pages/.

@foolip
Copy link
Member Author

foolip commented Aug 7, 2018

Alright, I've configured https://travis-ci.org/WICG/ResizeObserver in a way that I think will work. I'll merge this PR and watch the build and send follow-ups if it still doesn't work.

@foolip foolip merged commit 67213d8 into WICG:master Aug 7, 2018
@foolip foolip deleted the travis-deploy branch August 7, 2018 19:34
@foolip
Copy link
Member Author

foolip commented Aug 7, 2018

https://travis-ci.org/WICG/ResizeObserver/builds/413276563 ran successfully and pushed the result to 63967a7. The result is visible at https://wicg.github.io/ResizeObserver/#resize-observer-callback and includes the semicolon I added in #56.

Victory!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants