Allow just setting the elementtiming attribute #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the attribute is set it should trigger observation, even if it is set to the empty string. This is useful because doing something such as <img ... elementtiming> sets the attribute value to the empty string.
|
Chrome implementation change along with WPT will follow... ptal! |
|
So the use case for this is timing for images, where identification is URL based? |
|
Yea the use case requested was for images, although I think it should be consistent with text. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 21, 2019
This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 21, 2019
This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707947}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 21, 2019
This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707947}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 24, 2019
…elementtiming attribute, a=testonly Automatic update from web-platform-tests [ElementTiming] Allow empty but present elementtiming attribute This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707947} -- wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa wpt-pr: 19812
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Oct 24, 2019
…elementtiming attribute, a=testonly Automatic update from web-platform-tests [ElementTiming] Allow empty but present elementtiming attribute This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707947} -- wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa wpt-pr: 19812
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 27, 2019
…elementtiming attribute, a=testonly Automatic update from web-platform-tests [ElementTiming] Allow empty but present elementtiming attribute This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#707947} -- wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa wpt-pr: 19812 UltraBlame original commit: c2a24aab12db66f6f27a6ebf033cef186b6c2119
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 27, 2019
…elementtiming attribute, a=testonly Automatic update from web-platform-tests [ElementTiming] Allow empty but present elementtiming attribute This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#707947} -- wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa wpt-pr: 19812 UltraBlame original commit: c2a24aab12db66f6f27a6ebf033cef186b6c2119
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 27, 2019
…elementtiming attribute, a=testonly Automatic update from web-platform-tests [ElementTiming] Allow empty but present elementtiming attribute This CL changes the behavior in cases where the elementtiming attribute is set but not to a specific value, so that the affected elements are considered registered for observation. It also adds a test with image and text testcases. This follow the spec change at WICG/element-timing#38 Bug: 1011009 Change-Id: If33f55b0992545e6e13f108b923bbcfc546f4d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871638 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#707947} -- wpt-commits: 6174e0943360abb81f64a54205a7782531cddcaa wpt-pr: 19812 UltraBlame original commit: c2a24aab12db66f6f27a6ebf033cef186b6c2119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #37. When the attribute is set it should trigger observation, even if it is set to the empty string. This is useful because doing something such as <img ... elementtiming> sets the attribute value to the empty string.
Preview | Diff