Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check more keys that just Tab to determine if in keyboard mode #62

Closed
a11yup-old opened this issue Oct 31, 2017 · 1 comment
Closed

Comments

@a11yup-old
Copy link

I am using this polyfill on a project with a couple of modal dialogs that can be triggered from different parts of the app. Whenever I close such a dialog via the Enter or Escape key focus is reset to the original place manually via .focus().

Unfortunately the .focus-ring class does not seem to be added, because only the Tab key is considered when setting the hadKeyboardEvent.

Would it make sense to add more keys like Enter, Escape and Space and Arrows?
I already tried this in my project and it seems to be fine.

I can create a PR for this.

@a11yup-old
Copy link
Author

Just realised that there is a discussion in #54 already and #57 seems to address this. Didn't get that via their titles. Sorry about that. I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant