Add support for Spatial Audio rendering capability queries #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation dictionary.
GurpreetV
approved these changes
Jul 19, 2019
… of exposing a SpatialAudioFormat enum on the AudioConfiguration, we now expose a "spatialRendering" boolean.
|
This LGTM. @jernoble @jyavenard, want to give you a bit more time to review. |
|
@jernoble, @jyavenard, @mounirlamouri - Please take a look when you get a chance. |
jernoble
reviewed
Aug 23, 2019
index.bs
Outdated
| presume spatialRendering is not required. When <code>true</code>, the | ||
| user agent SHOULD only report this configuration as | ||
| <a for=MediaCapabilitiesInfo>supported</a> if it can support spatial | ||
| rendering without falling back to a non-spatial mix of the stream. |
There was a problem hiding this comment.
I would suggest amending this to: "the user agent SHOULD only report this configuration as supported if it can support spatial rendering for the current audio output device without failing back to a non-spatial mix of the stream."
There was a problem hiding this comment.
Thanks for the suggestion @jernoble. I have pushed a change that reflects this.
mounirlamouri
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SpatialAudioFormat enum type and a spatialFormat member to the AudioConfiguration dictionary to allow sites to query for spatial audio rendering capabilities. This addresses Issue #120
+@scottlow
+@GurpreetV
+@vi-dot-cpp
Preview | Diff