-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove [DelayWhilePrerendering] in Screen Capture API #225
Comments
Thank you! Would you be interested in sending a PR? |
Sure. I'll do that Monday
…On Sat, Dec 17, 2022, 11:21 AM Domenic Denicola ***@***.***> wrote:
Thank you! Would you be interested in sending a PR?
—
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE243TY6NIX3Q52BW62JN3WNWH25ANCNFSM6AAAAAAS6PU22M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 19, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are removed as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 19, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are removed as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 19, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are removed as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 19, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are removed as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 21, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are removed as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 21, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Dec 21, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1086033}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 21, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1086033}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 21, 2022
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1086033}
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Dec 21, 2022
This reverts commit 5fbd1e8. Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. Original change's description: > Reject getDisplayMedia calls without user activation > > This CL makes sure getDisplayMedia() returned promise reject with > InvalidStateError when called without user activation. > Note that speculation rules tests are updated as well[1]. > > [1] WICG/nav-speculation#225 > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > Bug: 1198918 > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1086033} Bug: 1198918 Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 Auto-Submit: Peter Williamson <petewil@chromium.org> Quick-Run: Peter Williamson <petewil@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1086147}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 21, 2022
This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. Original change's description: > Reject getDisplayMedia calls without user activation > > This CL makes sure getDisplayMedia() returned promise reject with > InvalidStateError when called without user activation. > Note that speculation rules tests are updated as well[1]. > > [1] WICG/nav-speculation#225 > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > Bug: 1198918 > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1086033} Bug: 1198918 Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 Auto-Submit: Peter Williamson <petewil@chromium.org> Quick-Run: Peter Williamson <petewil@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1086147}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 22, 2022
This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. Original change's description: > Reject getDisplayMedia calls without user activation > > This CL makes sure getDisplayMedia() returned promise reject with > InvalidStateError when called without user activation. > Note that speculation rules tests are updated as well[1]. > > [1] WICG/nav-speculation#225 > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > Bug: 1198918 > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1086033} Bug: 1198918 Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 Auto-Submit: Peter Williamson <petewil@chromium.org> Quick-Run: Peter Williamson <petewil@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1086147}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 22, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fix screen capture wpt Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: Ibc02b3681e5f00f3e5290c88421e3409513df0fd
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 27, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fixing permission policy tests Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 27, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fixing permission policy tests Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 27, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fixing permission policy tests Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 27, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fixing permission policy tests Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 27, 2022
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jan 4, 2023
…r activation, a=testonly Automatic update from web-platform-tests Reject getDisplayMedia calls without user activation This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1086033} -- wpt-commits: fa93f70273eb7f9a8210a4decc7c4aaf79b206eb wpt-pr: 37482
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Jan 5, 2023
…hout user activation", a=testonly Automatic update from web-platform-tests Revert "Reject getDisplayMedia calls without user activation" This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. Original change's description: > Reject getDisplayMedia calls without user activation > > This CL makes sure getDisplayMedia() returned promise reject with > InvalidStateError when called without user activation. > Note that speculation rules tests are updated as well[1]. > > [1] WICG/nav-speculation#225 > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > Bug: 1198918 > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1086033} Bug: 1198918 Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 Auto-Submit: Peter Williamson <petewil@chromium.org> Quick-Run: Peter Williamson <petewil@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1086147} -- wpt-commits: b8cffc496b5e3ec50597efd2d38e4595b43ba521 wpt-pr: 37640
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 9, 2023
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 13, 2023
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Jan 13, 2023
…r activation, a=testonly Automatic update from web-platform-tests Reject getDisplayMedia calls without user activation This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1086033} -- wpt-commits: fa93f70273eb7f9a8210a4decc7c4aaf79b206eb wpt-pr: 37482
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Jan 13, 2023
…hout user activation", a=testonly Automatic update from web-platform-tests Revert "Reject getDisplayMedia calls without user activation" This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. Original change's description: > Reject getDisplayMedia calls without user activation > > This CL makes sure getDisplayMedia() returned promise reject with > InvalidStateError when called without user activation. > Note that speculation rules tests are updated as well[1]. > > [1] WICG/nav-speculation#225 > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > Bug: 1198918 > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Commit-Queue: Fr <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/main@{#1086033} Bug: 1198918 Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 Auto-Submit: Peter Williamson <petewil@chromium.org> Quick-Run: Peter Williamson <petewil@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Peter Williamson <petewil@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1086147} -- wpt-commits: b8cffc496b5e3ec50597efd2d38e4595b43ba521 wpt-pr: 37640
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Jan 23, 2023
This reverts commit 085deea. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 23, 2023
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Jan 23, 2023
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Feb 1, 2023
…hout user activation", a=testonly Automatic update from web-platform-tests Reland "Reject getDisplayMedia calls without user activation" This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545} -- wpt-commits: 875fdac0d11bd1b75648d8830869f677f4046818 wpt-pr: 37683
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Feb 2, 2023
This reverts commit cdf104c. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deea. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 2, 2023
This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 2, 2023
This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 3, 2023
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Feb 3, 2023
…hout user activation", a=testonly Automatic update from web-platform-tests Reland "Reject getDisplayMedia calls without user activation" This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545} -- wpt-commits: 875fdac0d11bd1b75648d8830869f677f4046818 wpt-pr: 37683
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Feb 3, 2023
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 3, 2023
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Feb 3, 2023
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Feb 5, 2023
…alls without user activation"", a=testonly Automatic update from web-platform-tests Revert "Reland "Reject getDisplayMedia calls without user activation"" This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530} -- wpt-commits: 41ba61f3c06c216611b2f14dbcc1e55032135063 wpt-pr: 38334
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Feb 5, 2023
…r activation, a=testonly Automatic update from web-platform-tests Reject getDisplayMedia calls without user activation This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098} -- wpt-commits: ac2ff07ac0041f03bc8c8f8481cb5729b8086b25 wpt-pr: 38347
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Feb 7, 2023
…alls without user activation"", a=testonly Automatic update from web-platform-tests Revert "Reland "Reject getDisplayMedia calls without user activation"" This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530} -- wpt-commits: 41ba61f3c06c216611b2f14dbcc1e55032135063 wpt-pr: 38334
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Feb 7, 2023
…r activation, a=testonly Automatic update from web-platform-tests Reject getDisplayMedia calls without user activation This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098} -- wpt-commits: ac2ff07ac0041f03bc8c8f8481cb5729b8086b25 wpt-pr: 38347
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this issue
Mar 7, 2023
This reverts commit cdf104c. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deea. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} (cherry picked from commit a9d584e) Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1100530} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218370 Cr-Commit-Position: refs/branch-heads/5563@{chromium#207} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Mar 28, 2023
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Mar 28, 2023
This reverts commit cdf104c2c9bec928fe578719836cab8d5815759e. Reason for revert: This change breaks websites Original change's description: > Reland "Reject getDisplayMedia calls without user activation" > > This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. > > Reason for revert: This CL also now fixes permission policy tests > by making them run in sequences so that the emulated click is not > lost across tests. > > Original change's description: > > Revert "Reject getDisplayMedia calls without user activation" > > > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > > > Original change's description: > > > Reject getDisplayMedia calls without user activation > > > > > > This CL makes sure getDisplayMedia() returned promise reject with > > > InvalidStateError when called without user activation. > > > Note that speculation rules tests are updated as well[1]. > > > > > > [1] WICG/nav-speculation#225 > > > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > > > Bug: 1198918 > > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > > Cr-Commit-Position: refs/heads/main@{#1086033} > > > > Bug: 1198918 > > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > > Auto-Submit: Peter Williamson <petewil@chromium.org> > > Quick-Run: Peter Williamson <petewil@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Owners-Override: Peter Williamson <petewil@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1086147} > > Bug: 1198918 > Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 > Commit-Queue: Fr <beaufort.francois@gmail.com> > Reviewed-by: Elad Alon <eladalon@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095545} Bug: 1198918,1412364 Bug: b:267183725 Change-Id: I4eba562780cd15a9d7e50663d6b06fad3714af42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4217651 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1100530}
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Mar 28, 2023
This CL makes sure getDisplayMedia() returned promise reject with InvalidStateError when called without user activation. This is now gated by an experimental blink feature as it was revered several times before. Note that speculation rules tests are updated as well[1]. [1] WICG/nav-speculation#225 Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI Bug: 1198918 Change-Id: I9517012e76478b108d74bff432b71095ac7ba4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219093 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1101098}
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this issue
Jun 1, 2024
…hout user activation", a=testonly Automatic update from web-platform-tests Reland "Reject getDisplayMedia calls without user activation" This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: This CL also now fixes permission policy tests by making them run in sequences so that the emulated click is not lost across tests. Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: I456423c03c1430399f4b44e275a77e0411f6bda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125755 Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1095545} -- wpt-commits: 875fdac0d11bd1b75648d8830869f677f4046818 wpt-pr: 37683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
getDisplayMedia()
method in the Screen Capture API requires transient user activation.I believe this makes this API fit into the list of implicitly restricted APIs. Currently, it seems like the spec does not: https://wicg.github.io/nav-speculation/prerendering.html#screen-capture-patch
The text was updated successfully, but these errors were encountered: