Reland "Reject getDisplayMedia calls without user activation" #37644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1. Reason for revert: Fix screen capture wpt Original change's description: > Revert "Reject getDisplayMedia calls without user activation" > > This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf. > > Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7. > > The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related. > > Original change's description: > > Reject getDisplayMedia calls without user activation > > > > This CL makes sure getDisplayMedia() returned promise reject with > > InvalidStateError when called without user activation. > > Note that speculation rules tests are updated as well[1]. > > > > [1] WICG/nav-speculation#225 > > > > Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI > > > > Bug: 1198918 > > Change-Id: I530761d95e6db412582d0f19c0170803516c33f7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Elad Alon <eladalon@chromium.org> > > Commit-Queue: Fr <beaufort.francois@gmail.com> > > Cr-Commit-Position: refs/heads/main@{#1086033} > > Bug: 1198918 > Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423 > Auto-Submit: Peter Williamson <petewil@chromium.org> > Quick-Run: Peter Williamson <petewil@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Peter Williamson <petewil@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1086147} Bug: 1198918 Change-Id: Ibc02b3681e5f00f3e5290c88421e3409513df0fd
wpt-pr-bot
approved these changes
Dec 22, 2022
|
Close this PR because the Chromium CL cannot be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 085deeae4f99ba12f7982aae69f6576f7f18b9c1.
Reason for revert: Fix screen capture wpt
Original change's description:
Bug: 1198918
Change-Id: Ibc02b3681e5f00f3e5290c88421e3409513df0fd
Reviewed-on: https://chromium-review.googlesource.com/4111530
WPT-Export-Revision: 4bc28e2f95f373977b0683c42b9889b553094a85