-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be careful not to over-claim in "Userland libraries" #8
Comments
#16 seems unrelated to this? |
Yes thanks, I mixed #4 and this one up in the "Fixes"/"Closes" thingy. |
RxJS, tRPC, Apollo GraphQL, and Relay have nearly identical copies of Observable that match. The others vary in similarity. TanStacks react-query has one that’s very very close. |
Here's PR to address this: #23 (I forgot to put the issue # in the commit messages, sorry). |
@benlesh Thanks a lot for the PR. Do you think we're OK to close this given your updated prose? |
Yeah. |
I believe several of the "observable" implementations listed, don't conform to the observable contract referenced. It would be good to separate out the ones that do, from the ones that are vaguely in a similar conceptual area. The former give support directly to the proposed design in the explainer; the latter just tell us that this is a problem area worth solving, but perhaps with a completely different API.
The text was updated successfully, but these errors were encountered: