Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be careful not to over-claim in "Userland libraries" #8

Closed
domenic opened this issue Mar 27, 2023 · 6 comments · Fixed by #16
Closed

Be careful not to over-claim in "Userland libraries" #8

domenic opened this issue Mar 27, 2023 · 6 comments · Fixed by #16

Comments

@domenic
Copy link
Collaborator

domenic commented Mar 27, 2023

I believe several of the "observable" implementations listed, don't conform to the observable contract referenced. It would be good to separate out the ones that do, from the ones that are vaguely in a similar conceptual area. The former give support directly to the proposed design in the explainer; the latter just tell us that this is a problem area worth solving, but perhaps with a completely different API.

@domenic
Copy link
Collaborator Author

domenic commented May 26, 2023

#16 seems unrelated to this?

@domenic domenic reopened this May 26, 2023
@domfarolino
Copy link
Collaborator

Yes thanks, I mixed #4 and this one up in the "Fixes"/"Closes" thingy.

@benlesh
Copy link
Collaborator

benlesh commented Jun 1, 2023

RxJS, tRPC, Apollo GraphQL, and Relay have nearly identical copies of Observable that match.

The others vary in similarity. TanStacks react-query has one that’s very very close.

@benlesh
Copy link
Collaborator

benlesh commented Jun 7, 2023

Here's PR to address this: #23

(I forgot to put the issue # in the commit messages, sorry).

@domfarolino
Copy link
Collaborator

@benlesh Thanks a lot for the PR. Do you think we're OK to close this given your updated prose?

@benlesh
Copy link
Collaborator

benlesh commented Jul 2, 2023

Yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants