Long share requests may truncate with GET #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymeskhoury
approved these changes
Apr 29, 2019
level-2/index.html
Outdated
| @@ -737,6 +741,8 @@ <h3> | |||
| </li> | |||
| <li>If <var>value</var> is <code>undefined</code>, then continue. | |||
| </li> | |||
| <li>If <var>method</var> is <code>"GET"</code> and <var>value</var> exceeds 2000 bytes, the user agent MAY truncate <var>value</var>. | |||
There was a problem hiding this comment.
nit: Possibly reword as something like:
If method is GET and value exceeds 2000 bytes in length, the user agent MAY set value to the first 2000 bytes of value.
Allow share data to be truncated when method is GET and a member of the shared data exceeds 2000 bytes. User agents may need to avoid large GET requests, e.g. https://tools.ietf.org/html/rfc7230#section-3.1.1 "It is RECOMMENDED that all HTTP senders and recipients support, at a minimum, request-line lengths of 8000 octets."
ewilligers
force-pushed
the
risk-truncation
branch
from
5ed5f37
to
dace524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow share data to be truncated when method is GET and a member of the
shared data exceeds 2000 bytes.
User agents may need to avoid large GET requests,
e.g.
https://tools.ietf.org/html/rfc7230#section-3.1.1
"It is RECOMMENDED that all HTTP senders and recipients
support, at a minimum, request-line lengths of 8000 octets."
Preview | Diff