go: Add strucured header writer #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds ToString() method to the structured header types, and uses it from signer.go.
hajimehoshi
reviewed
Mar 13, 2019
| "unicode" | ||
| ) | ||
|
|
||
| func (ll ListOfLists) ToString() (string, error) { |
There was a problem hiding this comment.
String is more idiomatic in Go.
There was a problem hiding this comment.
Doesn't String() usually return just a string? This returns an error too.
There was a problem hiding this comment.
Right, but using To is not common in Go.
There is an actual usecase of String that also returns error: https://godoc.org/golang.org/x/text/encoding#Decoder.String
There was a problem hiding this comment.
Got it, thanks for finding the example. Done.
nyaxt
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ToString() method to the structured header types, and
uses it from signer.go.