Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust Environment Variables #72

Closed
ric-evans opened this issue Jan 17, 2023 · 1 comment
Closed

Robust Environment Variables #72

ric-evans opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ric-evans
Copy link
Contributor

ric-evans commented Jan 17, 2023

continuing from #70:

mqclient is used pretty low in the stack in skydriver and the skymap scanner, and it has a lot of configurable parts: timeouts (4ish), auth token(?), and prefetch. These are mostly init args from Queue, but the arg-forwarding can be error-prone and requires knowledge of multiple package call levels. So, let's replace these optional args' default values with env vars.

@ric-evans ric-evans added the enhancement New feature or request label Jan 17, 2023
@ric-evans ric-evans self-assigned this Jan 17, 2023
@ric-evans
Copy link
Contributor Author

It's not a usual use case to have only one queue per shell. This type of config better fits one layer up, at the application level. See Observation-Management-Service/ewms-pilot#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant