-
Notifications
You must be signed in to change notification settings - Fork 654
Return an array of avatar urls in different sizes for Comments and Users #1361
Conversation
rachelbaker
commented
Jun 19, 2015
- Add rest_get_avatars and deprecate rest_get_avatar
- Update Comment controller to use rest_get_avatars
- Update Users controller to use rest_get_avatars
…ar_urls inline comment
We now return an array of avatar urls that are keyed on the image size. This approach is the result of a discussion with @rmccue via the #core-rest-api Slack channel earlier this week. Example:
|
'type' => 'string', | ||
'author_avatar_urls' => array( | ||
'description' => 'Avatar URLs for the object author.', | ||
'type' => 'array', | ||
'format' => 'uri', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielbachhuber can I still use the uri
format with the array
type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're actually returning an object now, so it would be an object with specific properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WP-API/amigos #reviewmerge |
Hold off on a merge, I need to fix the schema. |
@WP-API/amigos #reviewmerge |
👍 |
Return an array of avatar urls in different sizes for Comments and Users