Skip to content
This repository has been archived by the owner on Sep 24, 2018. It is now read-only.

Ensure Terms link to their appropriate Taxonomy #1814

Merged
merged 2 commits into from
Dec 9, 2015
Merged

Ensure Terms link to their appropriate Taxonomy #1814

merged 2 commits into from
Dec 9, 2015

Conversation

danielbachhuber
Copy link
Member

Fixes #1296

@danielbachhuber danielbachhuber added this to the 2.0 Beta 9 milestone Dec 9, 2015
@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Member Author 

local ➜  ~  http GET wordpress-develop.dev/wp-json/wp/v2/categories/1
HTTP/1.1 200 OK

{
    "_links": {
        "about": [
            {
                "href": "http://wordpress-develop.dev/wp-json/wp/v2/taxonomies/category"
            }
        ],
        "collection": [
            {
                "href": "http://wordpress-develop.dev/wp-json/wp/v2/categories"
            }
        ],
        "self": [
            {
                "href": "http://wordpress-develop.dev/wp-json/wp/v2/categories/1"
            }
        ]
    },
    "count": 111,
    "description": "",
    "id": 1,
    "link": "http://wordpress-develop.dev/blog/category/uncategorized/",
    "name": "Uncategorized",
    "parent": 0,
    "slug": "uncategorized",
    "taxonomy": "category"
}

@danielbachhuber danielbachhuber mentioned this pull request Dec 9, 2015
Closed
rmccue
rmccue reviewed Dec 9, 2015
View reviewed changes
lib/endpoints/class-wp-rest-terms-controller.php
@@ -484,6 +484,9 @@ protected function prepare_links( $term ) {
'collection' => array(
'href' => rest_url( $base ),
),
'about' => array(
'href' => rest_url( sprintf( 'wp/v2/taxonomies/%s', $this->taxonomy ) ),
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing paren is off ;)

@rmccue
Copy link
Member

rmccue commented Dec 9, 2015

lgtm, needs standards tweak

danielbachhuber added a commit that referenced this pull request Dec 9, 2015
@danielbachhuber
Merge pull request #1814 from WP-API/1296-term-link-taxonomy
dbbf512 
Ensure Terms link to their appropriate Taxonomy
@danielbachhuber danielbachhuber merged commit dbbf512 into develop Dec 9, 2015
@danielbachhuber danielbachhuber deleted the 1296-term-link-taxonomy branch December 9, 2015 23:38
@davegreenwp davegreenwp mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
2.0 Beta 9
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @rmccue