Allow attaching media to posts on creation #294

Merged
merged 3 commits into from Jul 17, 2014

Conversation

Projects
None yet
2 participants
@pkevan
Contributor

pkevan commented Jun 5, 2014

Images can now be associated with posts, assuming they exist. Based on current xml-rpc method

Fixes #269

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jun 9, 2014

Member

Thanks! We'll review for 1.2 :)

Member

rmccue commented Jun 9, 2014

Thanks! We'll review for 1.2 :)

@rmccue rmccue added this to the 1.2 milestone Jun 9, 2014

@rmccue

This comment has been minimized.

Show comment
Hide comment
@rmccue

rmccue Jul 7, 2014

Member

Looking pretty good, but we should check the correct permissions for the type instead, as it could be attached to a CPT.

Member

rmccue commented Jul 7, 2014

Looking pretty good, but we should check the correct permissions for the type instead, as it could be attached to a CPT.

@rmccue rmccue removed the Review label Jul 7, 2014

Paul Kevan
Permissions to upload by post id changed
- Now checks the post type of the post id being passed
- Rename variable to make it clearer we are trying to upload to it (post_parent)
@pkevan

This comment has been minimized.

Show comment
Hide comment
@pkevan

pkevan Jul 7, 2014

Contributor

Good point Ryan. I've changed the pull to check permissions based on the type of the post_id

Contributor

pkevan commented Jul 7, 2014

Good point Ryan. I've changed the pull to check permissions based on the type of the post_id

rmccue added a commit that referenced this pull request Jul 17, 2014

Merge pull request #294 from pkevan/media-upload-to-post
Allow attaching media to posts on creation

@rmccue rmccue merged commit b1033fb into WP-API:master Jul 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rmccue rmccue changed the title from Allows adding of post id through post vars to Allow attaching media to posts on creation Jul 17, 2014

@rmccue rmccue self-assigned this Jul 17, 2014

kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014

Merge pull request #294 from pkevan/media-upload-to-post
Allow attaching media to posts on creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment