This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Allow attaching media to posts on creation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We'll review for 1.2 :) |
|
Looking pretty good, but we should check the correct permissions for the type instead, as it could be attached to a CPT. |
- Now checks the post type of the post id being passed - Rename variable to make it clearer we are trying to upload to it (post_parent)
|
Good point Ryan. I've changed the pull to check permissions based on the type of the post_id |
rmccue
added a commit
that referenced
this pull request
Jul 17, 2014
Allow attaching media to posts on creation
rmccue
changed the title
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
Allow attaching media to posts on creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images can now be associated with posts, assuming they exist. Based on current xml-rpc method
Fixes #269