Support manipulating users #2
Conversation
| * @package WordPress API Client | ||
| * @subpackage Entities | ||
| */ | ||
| class WPAPI_User { |
There was a problem hiding this comment.
@rmccue What do you think about having this and WPAPI_Post extend a WPAPI_Entity class?
There was a problem hiding this comment.
Sounds good to me, but should be called Object rather than Entity for consistency with core.
On Wed, May 7, 2014 at 10:48 AM, Daniel Bachhuber
notifications@github.com wrote:
@@ -0,0 +1,68 @@
+<?php
+
+/**
- * User entity object
- * @Package WordPress API Client
- * @subpackage Entities
*/
Reply to this email directly or view it on GitHub:
+class WPAPI_User {
@rmccue What do you think about having this andWPAPI_Postextend aWPAPI_Entityclass?
https://github.com/WP-API/client-php/pull/2/files#r12357627
There was a problem hiding this comment.
Ok. And is there a reason you went with interface over abstract class for collections? I think the former will lead to a bunch of duplicate code
There was a problem hiding this comment.
We can add a base class (Collection_Base) as well, but interfaces should be used to represent interfaces. Means we separate the implementation from the interface.
On Wed, May 7, 2014 at 10:52 AM, Daniel Bachhuber
notifications@github.com wrote:
@@ -0,0 +1,68 @@
+<?php
+
+/**
- * User entity object
- * @Package WordPress API Client
- * @subpackage Entities
*/
Reply to this email directly or view it on GitHub:
+class WPAPI_User {
Ok. And is there a reason you went with interface over abstract class for collections? I think the former will lead to a bunch of duplicate code
https://github.com/WP-API/client-php/pull/2/files#r12357765
No description provided.