Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.3 to .travis.yml; Remove 7.0 #1579

Closed
5 tasks
benlk opened this issue Dec 3, 2018 · 4 comments
Closed
5 tasks

Add PHP 7.3 to .travis.yml; Remove 7.0 #1579

benlk opened this issue Dec 3, 2018 · 4 comments
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: pre-launch todo
Projects

Comments

@benlk
Copy link
Collaborator

benlk commented Dec 3, 2018

@benlk benlk added this to the 0.6.1 - Bugfixes milestone Dec 3, 2018
@benlk benlk changed the title Add PHP 7.3 to .travis.yml Add PHP 7.3 to .travis.yml; Remove 7.0 Dec 3, 2018
@benlk
Copy link
Collaborator Author

benlk commented Dec 3, 2018

This is blocked by Travis not yet supporting PHP 7.3 yet; their latest build environment doesn't have PHP 7.3 yet. It only has 5.6, 7.1, and 7.2.

@benlk
Copy link
Collaborator Author

benlk commented Aug 22, 2019

If we want PHP 7.3, we will need to switch to the Xenial build environment: https://docs.travis-ci.com/user/reference/bionic/#php-support

This will require dropping PHP 5.6 support, which we should be okay with doing because PHP 5.6 went end-of-life at the end of 2018: https://www.php.net/eol.php

@benlk benlk added this to To do in Largo 0.7 via automation Aug 22, 2019
@benlk benlk added Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. labels Aug 22, 2019
@benlk
Copy link
Collaborator Author

benlk commented Aug 22, 2019

@benlk
Copy link
Collaborator Author

benlk commented Mar 4, 2020

Closing in favor of #1801, which is more up-to-date.

@benlk benlk closed this as completed Mar 4, 2020
Largo 0.7 automation moved this from To do to Done Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: pre-launch todo
Projects
Largo 0.7
  
Done
Development

No branches or pull requests

1 participant