Related Posts widget: make byline and thumbnail placement options work

[benlk]

Changes

• "show date" option text is renamed to "show byline" to match internal variable
• show_byline option now actually toggles the presence of the byline; defaults to not
• Before/After headline option for thumbnail placement now has effect
• Styles for proper alignment of thumbnail in before and after positions

Why

Because we had these options in the widget, but they weren't doing anything.

For #1242

[aschweigert]

Is the before/after option for the thumbnail a thing we actually want/need? Seems overly complicated for me unless there's a particularly good reason for it.

[benlk]

I'm in favor of removing it. It is a needless complication, and it makes more sense for that to be a child-theme styles decision than a per-widget decision.

[aschweigert]

go for it

[benlk]

D we want an option to disable showing the thumbnail at all?

[benlk]

Before/After option and styles have been removed.

[aschweigert]

the markup that uses that option is still in the widget though...right?

[benlk]

Not sure what you mean by "the markup that uses that option" - the only difference to the markup on the thumbnail and the link inside it is that the thumbnail no longer has an alignleft class on it, and instead gets the float: left from the widget's styles.

[aschweigert]

I see, there was just a comment in there that made it look like that option was still present. Removed that and I think we're fine to merge this.