forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-width images regardless of alignment when up to 768px #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alignright and .alignleft. Fix caption styles on aligned images.
benlk
added
type: improvement
community contribution
category: styles
affects lots of styles, requiring visual testing
category: gutenberg
Relating to general Gutenberg compatibility
labels
Apr 20, 2019
To-do list:
|
joshdarby
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: gutenberg
Relating to general Gutenberg compatibility
category: styles
affects lots of styles, requiring visual testing
community contribution
type: improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened by @seanchayes in #1630 for #1611. Opening from within INN/Largo so that I can push a bunch of work from on top of his base.
Changes
display: table
on the captioned figure. The non-caption width changes here were causing the caption to appear in the form of a few-word-wide column below and to the left of the image, rather than being the full width of it."Before" screenshots:
"After" screenshots: