forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Staff List Widget, [roster] shortcode, and related user meta forms #1763
Open
benlk
wants to merge
9
commits into
trunk
Choose a base branch
from
1505-remove-staff-list-widget
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shortcode in Largo, but not the corresponding styles.
@joshdarby please look at this PR and the corresponding issue and plugin, and chime in on where the metadata should be saved. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
status: needs review
type: feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
[roster]
shortcodeTo Do
Because the meta boxes used by the Staff List Widget and the[roster]
shortcode are also used for bylines, specifically the "job title" meta and the "show_email" meta, we're going to have to figure out how Largo and this plugin interact. Who is responsible for providing the form?I think this might work best if Largo keeps the complete form, but unregisters the plugin's corresponding form functions. The metadata would remain the same across both the theme and the plugin.Why
Because we're pulling this functionality out of Largo as part of #1505 and https://github.com/INN/staff
Testing/Questions
Features that this PR affects:
[roster]
shortcodeQuestions that need to be answered before merging:
[ ] do we need to make any updates to https://github.com/INN/staff ?Per the 2020-03-03 planning proposals doc we are cancelling this plugin[ ] does the migration function work?Steps to test this PR:
trunk
:[roster]
shortcode to a page[roster]
shortcode: the shortcode should be visible