Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Rewards Factory #32

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Rename Rewards Factory #32

merged 1 commit into from
Jan 6, 2021

Conversation

goobta
Copy link
Member

@goobta goobta commented Dec 15, 2020

Closes #23. tl;dr of why this is here--test_rewards_factory.py has tests for more than the reward factory, so just cleaning things up a bit.

@goobta goobta added the cleanliness refactoring the code to make it more elegant label Dec 15, 2020
@coveralls
Copy link

coveralls commented Dec 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 423408560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.082%
Totals Coverage Status
Change from base Build 406391266: 0.05%
Covered Lines: 716
Relevant Lines: 730
💛 - Coveralls

This was referenced Dec 17, 2020
Merged
Merged
mahajanrevant
mahajanrevant reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the hardest PR to review. Thank you for all your work. Approving and merging.

@mahajanrevant mahajanrevant merged commit 674bfe8 into master Jan 6, 2021
@goobta goobta deleted the agupta231-rewards-test-rename branch January 7, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahajanrevant mahajanrevant mahajanrevant approved these changes

Assignees
No one assigned
Labels
cleanliness refactoring the code to make it more elegant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TestRewardsFactory
3 participants
@goobta @coveralls @mahajanrevant