Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Home Position Reward #33

Merged
merged 6 commits into from
Jan 8, 2021
Merged

Create Home Position Reward #33

merged 6 commits into from
Jan 8, 2021

Conversation

goobta
Copy link
Member

@goobta goobta commented Dec 17, 2020

Closes #24.

Basically as mentioned before, this gives the maximal reward (~1) for the robot reaching the home position (quadrupedal standing). Big thing to note here is that the reward is dependent on both the height and the orientation, as shown in the line below:

return 0.25 * orientation_reward + 0.75 * height_reward

However, notice that these are being weighted and summed together. This functionality is also built into our rewards_factory, but I just thought it was cleaner to implement it this way as the quadrupedal standing max height will be different from the bipedal standing one. However, if the relative weights between the two rewards needs to be optimized, then they will probably have to be split up so that W&B and tune it for us.

Note that #32 should probably be merged first cause that renames the test_rewards.py file, which this PR modifies. This PR is branched off of the previous one, so if #32 gets merged, this shouldn't have any problems.

@goobta goobta added the new feature New feature or request label Dec 17, 2020
@coveralls
Copy link

coveralls commented Dec 17, 2020

Pull Request Test Coverage Report for Build 427141405

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 98.123%

Totals Coverage Status
Change from base Build 406391266: 0.09%
Covered Lines: 732
Relevant Lines: 746

💛 - Coveralls

Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same code in one of the other reviews so those comments are applicable. I can approve this PR and we can resolve any concerning issues in the PR after this?

examples/solo8_vanilla/observation_dump.py Show resolved Hide resolved
@goobta
Copy link
Member Author

goobta commented Jan 7, 2021

Since this is one of the earlier PRs, do you want me to merge this one first? idk if you left most of your comments in the other PRs or what would make this easiest for ya...

@mahajanrevant
Copy link
Contributor

I am okay with you merging this in because I looked at the other PR before this so all my relevant comments are there

Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are present in another PR. All relevant comments are present in that PR. Giving this PR approval based on this

@goobta goobta merged commit 649eca8 into master Jan 8, 2021
@goobta goobta deleted the agupta231-home-reward branch January 8, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A reward for getting the robot from flat on the ground to the home position
3 participants