feat: add throttle on search component #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo-mesnil
reviewed
Mar 19, 2020
| setResults(data || []) | ||
| } | ||
| if (!handleInputChangeRef.current) { | ||
| handleInputChangeRef.current = handleThrottle(async value => { |
There was a problem hiding this comment.
il n'y a pas moyen de faire cela en interne sans passer par lodash ? :)
il faudrait aussi tester car ce genre de composant est assez sensible ^^
There was a problem hiding this comment.
pour le throttle custom c'est good,
Pour les tests j'en ai pas rajouté car la partie que touche l'improvment est couvert par
shows options when searching
anucreative
reviewed
Mar 19, 2020
anucreative
approved these changes
Mar 19, 2020
theo-mesnil
approved these changes
Mar 19, 2020
| setResults(data || []) | ||
| } | ||
| if (!handleInputChangeRef.current) { | ||
| handleInputChangeRef.current = handleThrottle(async value => { |
P1X3L
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.