Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure Lint #218

Closed
aabenoja opened this issue Sep 21, 2018 · 1 comment
Closed

Reconfigure Lint #218

aabenoja opened this issue Sep 21, 2018 · 1 comment

Comments

@aabenoja
Copy link
Contributor

The current configuration is giving some false positives. For example, you can remove the propTypes objects from Button and npm run lint will still pass.
@aabenoja
Copy link
Contributor Author

This is related to jsx-eslint/eslint-plugin-react#1958. This fix was merged after its recent 7.11.1 release.

Dropping down to eslint-plugin-react@7.10.0 will allow react/prop-types to trigger the expected error in the scenario described above, but it still does not correctly return an error for defaultProps.

@aabenoja aabenoja mentioned this issue Nov 19, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevematney @aabenoja