Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move negative metric values into lowest bucket #3048

Open
JONBRWN opened this issue Nov 5, 2019 · 0 comments
Open

Move negative metric values into lowest bucket #3048

JONBRWN opened this issue Nov 5, 2019 · 0 comments

Comments

@JONBRWN
Copy link
Contributor

JONBRWN commented Nov 5, 2019

What is the current behavior?

Currently, if there is a negative time difference between the receiving worker and the sending worker, latency metrics for the network time computation end up in the largest bin possible due to underflow.

What is the expected behavior?

In the ideal world, machines would be perfectly synced. Since this tends to not be the case from time to time, we should insert underflow metrics into the lowest bin as to not negatively skew the upper percentiles with a disproportionately large value that does not represent a real latency value.

This is currently only visible in the network time computation and should be addressed there. Updating other metric areas should happen only if this issue becomes visible elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant