Add apns-push-type header #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great to find this PR, very nice! seems we're requiring exactly that for deltachat/notifiers#22 |
|
Yep, just tested, works as expected |
|
we're using this PR also for https://github.com/deltachat/notifiers in practise meanwhile, works like a charm! is there sth. we can help that this PR gets merged? |
chris13524
approved these changes
Apr 16, 2024
| /// this header is required or optional. | ||
| /// | ||
| /// see https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns#4294485 | ||
| pub enum PushType { |
There was a problem hiding this comment.
Looks like complication is variant missing, but this may have been added in a more recent version.
threema-donat
pushed a commit
to threema-donat/a2
that referenced
this pull request
Apr 23, 2024
* Add apns-push-type header * Add unit test and re-export PushType * Derive PartialEq and Eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
apns-push-typeheader (mostly to support background notifications, but I mapped all the possible values).Due Dilligence