Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@walletconnect NPM version 1.0.17 missing build-registry script #317

Closed
RyRy79261 opened this issue Jul 20, 2020 · 2 comments
Closed

@walletconnect NPM version 1.0.17 missing build-registry script #317

RyRy79261 opened this issue Jul 20, 2020 · 2 comments

Comments

@RyRy79261
Copy link

Description

The current published version on NPM is version 1.0.17, which doesn't match the github releases.

This version includes, as part of the qrcode-modal package's build script, a call to ./scripts/build-registry.js which is not present in the repo.

This leads to crashes in any package making use of this version on install.

error .../node_modules/@walletconnect/qrcode-modal: Command failed.
Exit code: 1
Command: node ./scripts/build-registry.js
...
Error: Cannot find module

Screenshot_20200720_115015
Screenshot_20200720_115048
@RyRy79261 RyRy79261 mentioned this issue Jul 20, 2020
Closed
@pedrouid
Copy link
Contributor

my bad that wasn't supposed to be a postinstall... I will publish a fix in a couple of seconds

@pedrouid
Copy link
Contributor

Published on v1.0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pedrouid @RyRy79261