Adds Kadena example #70
Conversation
|
@ashwinvandijk is attempting to deploy a commit to the WalletConnect Team on Vercel. A member of the Team first needs to authorize it. |
ash-vd
force-pushed
the
feat/kadena-example
branch
3 times, most recently
from
14ac366
to
12f7a0a
Compare
ash-vd
force-pushed
the
feat/kadena-example
branch
3 times, most recently
from
3544328
to
80827ba
Compare
ash-vd
force-pushed
the
feat/kadena-example
branch
from
80827ba
to
1bd03f2
Compare
ash-vd
force-pushed
the
feat/kadena-example
branch
from
1bd03f2
to
81b9ab1
Compare
ash-vd
force-pushed
the
feat/kadena-example
branch
from
81b9ab1
to
fcd2bf5
Compare
|
@bkrem This one is ready for review if you (or somebody of the WC-team) has the time. Thanks! |
|
@chadyj We submitted an example of how to make a connection to the Kadena blockchain. Can you take a look at it so we can move on, on our side, if this is the way to go? |
|
Hi @ashwinvandijk, @Randynamic, Thanks for putting in time to integrate Kadena with our examples. On our side every additional chain also entails additional maintenance and complexity considerations for our team, so we're generally careful when it comes to adding new chains unless it's a no-brainer. We're not familiar with Kadena (which may well be on us of course!), but since you seem to be your own L1, could you highlight some dapps and wallets that already support Kadena? Generally we recommend teams for less widely known chains to fork the examples, add support (as you have here) and thus use our examples to "piggy-back" example apps/wallets for ecosystem-specific usage :) |
|
Hey @bkrem, Sorry totally missed your reply. Best wishes for 2023!
Here you can find a list of projects on our platform. And we would love them all to work with Wallet Connect. Maintenance-wise, our team/community can help on that part if we need to make changes, etc. Otherwise, we will indeed add it to our own repo. But it would be great to get this PR merged. Hope to hear from you soon. Cheers! |
|
Developer of Linx Wallet here, i support this PR to the fullest. Would be great if we could get some documentation about the Kadena standard in the WalletConnect Docs / example repo. We are about to launch our wallet in beta with full WalletConnect v2 support for Kadena, having this information easily available for dApp developers is pretty important. Lots of projects are currently building on Kadena as it is a scalable POW network. |
|
I endorse this too, please merge. The PR itself looks cleanly written. Just need to fix the merge conflicts, @ash-vd . |
|
@ash-vd Apologies that this PR stalled out. Could you update the PR + fix conflicts, then we'll get this reviewed and merged for good 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ash-vd Dapp build is failing due to an outdated dependency import. I've added two tweaks that should fix the build. |
|
@bkrem Just a subtle nudge that this is ready for another try :) |
|
@ash-vd awesome thanks for the quick fixes, all good from my side 🚀 Think it just needs a final sync with upstream |
ash-vd
force-pushed
the
feat/kadena-example
branch
from
4b08144
to
9a119a6
Compare
No description provided.