Merge pull request #8 from jorgecarleitao/fix_ub

Fixed UB
WanzenBug · Jan 30, 2022 · d71d677 · d71d677
2 parents 690742a + 8f8bc47
commit d71d677
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -80,11 +80,11 @@ fn append_from_within<T>(seif: &mut Vec<T>, src: ops::Range<usize>) where T: Cop
     unsafe {
         // This is safe because reserve() above succeeded,
         // so `seif.len() + count` did not overflow usize
-        ptr::copy_nonoverlapping(
-            seif.get_unchecked(src.start),
-            seif.get_unchecked_mut(vec_len),
-            count,
-        );
+        // Derive both `src_ptr` and `dest_ptr` from the same loan
+        let ptr = seif.as_mut_ptr();
+        let src_ptr = ptr.add(src.start);
+        let dest_ptr = ptr.add(vec_len);
+        ptr::copy_nonoverlapping(src_ptr, dest_ptr, count);
         seif.set_len(vec_len + count);
     }
 }