Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UB #8

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fixed UB #8

merged 1 commit into from
Jan 30, 2022

Conversation

jorgecarleitao
Copy link
Contributor

This PR addresses an error whereby running cargo miri test fails. This is caused because the mut pointer gets invalidated when a non-mut pointer is created.

This is a backport of rust-lang/rust#85610 (we could consider using it, since it is stable).

@jorgecarleitao
Copy link
Contributor Author

@jorgecarleitao
Copy link
Contributor Author

@WanzenBug , if you no longer have time to maintain this crate, would it be ok for me to fork it and release in crates with the above fix (or alternatively, give me write permissions to do so?).

This crate is quite relevant for the ecosystem, and it would be nice to be able to offer continuity to it.

@WanzenBug
Copy link
Owner

Sorry, this PR must have been drowned out when catching up my notifications after Christmas.

I'll still merge PRs if any issues are noticed, but hopefully everyone will just use the version from the stdlib. I should probably reference that in the README :)

@WanzenBug WanzenBug merged commit d71d677 into WanzenBug:master Jan 30, 2022
@jorgecarleitao jorgecarleitao deleted the fix_ub branch January 30, 2022 22:27
@jorgecarleitao
Copy link
Contributor Author

fwiw, this crate is pretty much used - libflate depends on it, and pretty much the whole data engineering stack depends on that :)

@WanzenBug
Copy link
Owner

Yeah, my most popular crate, completely by accident, because I implemented some-ones RFC idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants