Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: change WithXyz(...) parameter names to 'value' #70

Closed
amis92 opened this issue Oct 31, 2019 · 2 comments
Closed

Breaking change: change WithXyz(...) parameter names to 'value' #70

amis92 opened this issue Oct 31, 2019 · 2 comments
Labels
enhancement
Milestone
0.8

Comments

@amis92
Copy link
Member

amis92 commented Oct 31, 2019

This aligns with actual property setters (they have the magical value variable). Also aligns with RecordGenerator's change: amis92/RecordGenerator#59
@amis92
Copy link
Member Author

amis92 commented Nov 1, 2019

Also change casing of all method parameters to be camelCased instead of PascalCased.

@amis92 amis92 added this to the 0.8 milestone Nov 5, 2019
@amis92
Copy link
Member Author

amis92 commented Nov 13, 2019

Also, make collection "mutators" (e.g. WithModifiers overloads other than WithModifiers(ModifierListNode)) be extension methods.

amis92 added a commit that referenced this issue Nov 14, 2019
@amis92
refactor: Change With parameter name to 'value'
bf055f8 
Also make all parameters lowercase (constructors, mutators, Updates)

closes #70
@amis92 amis92 closed this as completed in b2e84c2 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@amis92