Use the more conventional camel case for generated parameters #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amis92
requested changes
Jul 24, 2019
amis92
requested changes
Jul 24, 2019
Those being: - get - set - add - remove
Done with 5506650. |
amis92
reviewed
Jul 25, 2019
amis92
reviewed
Jul 25, 2019
test/Amadevus.RecordGenerator.Test/RecordNamingConventionsTests.cs
Outdated
Show resolved
Hide resolved
amis92
requested changes
Jul 25, 2019
src/Amadevus.RecordGenerator.Generators/RecordPartialGenerator.cs
Outdated
Show resolved
Hide resolved
Broken by commit 8ac523c.
[xUnit.net 00:00:00.44] Amadevus.RecordGenerator.Test:
Skipping test case with duplicate ID f4964700a5ae6318d746f8f9e7f17b599fcfdcaf:
Parameter_Name_Uses_Camel_Case(type: "Builder", method: "set_Id", name: "value")
Parameter_Name_Uses_Camel_Case(type: "Builder", method: "set_Id", name: "value")
[xUnit.net 00:00:00.44] Amadevus.RecordGenerator.Test:
Skipping test case with duplicate ID '3bc3e875c6bc477ff0e62177a965bccb12311bc1:
Parameter_Name_Uses_Camel_Case(type: "Builder", method: "set_Name", name: "value")
Parameter_Name_Uses_Camel_Case(type: "Builder", method: "set_Name", name: "value")
amis92
approved these changes
Jul 25, 2019
|
I'm in the middle of changing CI (appveyor->azure pipelines), so please hold on, I'll merge it when the move-over is done. |
Meanwhile, wanted to say thanks for all your prompt reviews. It's fun working on a project where the maintainer is super responsive and detail-oriented. |
|
Seems like you got the tests sorted out with 6430ed6 so I merged with master and the tests are passing (including on AppVeyor)! 🎉 |
|
Follow-up for #28 (analyzer asserting property names are case-insensitive different, e.g. no properties like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #57.