Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show rank for next droid #2727

Merged
merged 5 commits into from Jul 5, 2022

Conversation

gantsevdenis
Copy link
Contributor

Show the icon for the next droid.
Some UI bike-shedding:

  • should it be shown when nothing is being built? If it's not, then I have to start building something to know what rank it will be. If it is, then it's kinda awkard showing a rank icon over an empty queue
    empty-queue-icon

image

@lgtm-com

This comment was marked as outdated.

@lgtm-com

This comment was marked as outdated.

src/hci/manufacture.cpp Outdated Show resolved Hide resolved
@KJeff01
Copy link
Member

KJeff01 commented Jun 6, 2022

Nice! Now I won't have to remember exactly how many units I recycled to put exp on something.

@KJeff01 KJeff01 added this to the 4.3.0-beta1 milestone Jun 8, 2022
@KJeff01
Copy link
Member

KJeff01 commented Jul 4, 2022

@gantsevdenis Is this PR finished? Also fix that indent cause I ain't going to, lol.

@lgtm-com

This comment was marked as outdated.

@gantsevdenis
Copy link
Contributor Author

@KJeff01 should be good now

src/display3d.h Outdated Show resolved Hide resolved
src/hci/manufacture.cpp Outdated Show resolved Hide resolved
src/hci/manufacture.cpp Outdated Show resolved Hide resolved
src/hci/manufacture.cpp Outdated Show resolved Hide resolved
@KJeff01
Copy link
Member

KJeff01 commented Jul 5, 2022

Works good and aside from some minor formatting it looks good to me. 👍

@lgtm-com
Copy link

lgtm-com bot commented Jul 5, 2022

This pull request introduces 1 alert when merging bdfeefd into 21046e5 - view on LGTM.com

new alerts:

  • 1 for FIXME comment

@KJeff01 KJeff01 merged commit 28dfe21 into Warzone2100:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants