Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider context support #208

Open
dgl opened this issue May 9, 2019 · 0 comments
Open

Reconsider context support #208

dgl opened this issue May 9, 2019 · 0 comments

Comments

@dgl
Copy link

dgl commented May 9, 2019

Hi, I saw #103, but I think it is worth revisiting that now.

It would be useful to have context support for timeouts and tracing.

There's a comment on #103 that this won't mix with io.Reader, but see for example the newer google storage API at https://godoc.org/cloud.google.com/go/storage which uses that interface and supports context on top of it.

I think maybe using a model a bit like http.Request does now of having a .WithContext could work with minimal API changes (and/or add *Context versions of functions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant