We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assembly.FullName
Culture=...
5.3.0
.NET Framework 4.6.1
Windows
From migrating from dnlib to AsmResolver I noticed that Assembly.FullName is not including Culture= part.
dnlib
AsmResolver
Culture=
Read .dll file as bytes and try the sample code below:
.dll
public static void TestFullName(byte[] assemblyData) { string? dnLibFullName; { using var module = ModuleDefMD.Load(assemblyData, new ModuleContext()); dnLibFullName = module.Assembly.FullName; } string? asmResolverFullName; { var module = ModuleDefinition.FromBytes(assemblyData); asmResolverFullName = module.Assembly!.FullName; } string? assemblyNameFullName; { var assembly = Assembly.Load(assemblyData); assemblyNameFullName = assembly.GetName().FullName; } // "System.Security.Principal.Windows, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" Console.WriteLine(dnLibFullName); // "System.Security.Principal.Windows, Version=4.1.3.0, PublicKeyToken=b03f5f7f11d50a3a" Console.WriteLine(asmResolverFullName); // "System.Security.Principal.Windows, Version=4.1.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" Console.WriteLine(assemblyNameFullName); if (dnLibFullName != asmResolverFullName) { throw new Exception("Full name is not equals!"); } }
The sample code doesn't throw the exception
The sample code throws the exception
No response
The text was updated successfully, but these errors were encountered:
Thanks for the catch. This is implemented in 9155d46, and will be present in 5.4.0.
Sorry, something went wrong.
No branches or pull requests
AsmResolver Version
5.3.0
.NET Version
.NET Framework 4.6.1
Operating System
Windows
Describe the Bug
From migrating from
dnlib
toAsmResolver
I noticed thatAssembly.FullName
is not includingCulture=
part.How To Reproduce
Read
.dll
file as bytes and try the sample code below:Expected Behavior
The sample code doesn't throw the exception
Actual Behavior
The sample code throws the exception
Additional Context
No response
The text was updated successfully, but these errors were encountered: