Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some examples and update README.md #136

Closed
wants to merge 4 commits into from

Conversation

marinlauber
Copy link
Member

This adds the examples previously in #113 and updates the README to list all available examples and provide a short desciption.

examples/TwoD_LidCavity.jl Outdated Show resolved Hide resolved
end
end
end
@fastmath function WaterLily.mom_step!(a::Flow{N},b::AbstractPoisson) where N
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that this works. But it would be better to have an interface so a user can pass a BC function and we would just substitute it in mom_step! internally.

examples/TwoD_Triangle.jl Outdated Show resolved Hide resolved
examples/TwoD_Triangle.jl Outdated Show resolved Hide resolved
examples/TwoD_Square.jl Outdated Show resolved Hide resolved
examples/TwoD_Square.jl Outdated Show resolved Hide resolved
examples/TwoD_LidCavity.jl Outdated Show resolved Hide resolved
@b-fg
Copy link
Member

b-fg commented Jun 27, 2024

These are all nice examples, thanks! Left some comments, basically on improving how we hints users can also use GPU to run the cases. I have tested them all locally for CPU and GPU (except for the Bodies case) and they run fine!

Also, about the BC part, would be nice to let the user pass a function without having to rewrite mom_step!. Maybe future work though.

marinlauber and others added 3 commits June 28, 2024 09:27
Improve hinting possibility to use CuArray

Co-authored-by: Bernat Font <17761372+b-fg@users.noreply.github.com>
@marinlauber
Copy link
Member Author

@b-fg can we merge this?

@b-fg
Copy link
Member

b-fg commented Jul 5, 2024

Do you want to try to create and interface for a user-defined BC (as in the lid-driven cavity case)? Rewriting the whole mom_step! is an overkill I think.

@marinlauber
Copy link
Member Author

I will close this pull request as the examples will be moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants