-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some examples and update README.md #136
Conversation
end | ||
end | ||
end | ||
@fastmath function WaterLily.mom_step!(a::Flow{N},b::AbstractPoisson) where N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that this works. But it would be better to have an interface so a user can pass a BC function and we would just substitute it in mom_step!
internally.
These are all nice examples, thanks! Left some comments, basically on improving how we hints users can also use GPU to run the cases. I have tested them all locally for CPU and GPU (except for the Also, about the BC part, would be nice to let the user pass a function without having to rewrite |
Improve hinting possibility to use CuArray Co-authored-by: Bernat Font <17761372+b-fg@users.noreply.github.com>
@b-fg can we merge this? |
Do you want to try to create and interface for a user-defined |
I will close this pull request as the examples will be moved. |
This adds the examples previously in #113 and updates the README to list all available examples and provide a short desciption.