Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualizing the KS test results #25

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Visualizing the KS test results #25

merged 6 commits into from
Jan 19, 2023

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Jan 18, 2023

Here is a notebook that visualizes the KS test analysis, plus one example distribution.

In addition to carefully reviewing the PR, please also let me know the command you have been using to nbconvert the ipynb file so that we can keep internally consistent.

@jenna-tomkinson
Copy link
Member

@gwaybio
The command I always use is:

jupyter nbconvert --to python notebook.ipynb

I can now see why it is easier to review a .py file.

@gwaybio
Copy link
Member Author

gwaybio commented Jan 18, 2023

done, @jenna-tomkinson back to you!

jenna-tomkinson
jenna-tomkinson approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All my comments are questions in regard to the process used for this so I can get a better understanding for future use in other projects.

5_analyze_data/notebooks/KS-test_analysis/visualize_ks_test.py Outdated
# In[2]:


output_fig_dir <- "figures"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whole thing written in R language but in a python file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! it is supposed to be a .r file. The command jupyter nbconvert --to python notebook.ipynb is not compatible with r notebooks. I used this instead: jupyter nbconvert --to=script --FilesWriter.build_directory=. *.ipynb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see e5fc843)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting! This is very good to know!

5_analyze_data/notebooks/KS-test_analysis/visualize_ks_test.py Outdated


suppressPackageStartupMessages(library(ggplot2))
suppressPackageStartupMessages(library(dplyr))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this importing the libraries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! (the library()) syntax is equivalent to import statements in python)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay so this is the import libraries for R! I am now getting this whole file was an R file.

5_analyze_data/notebooks/KS-test_analysis/visualize_ks_test.py Outdated

# Load and process KS-test data
ks_file <- file.path("data", "nf1_kstest_two_sample_results.csv")
ks_df <- readr::read_csv(ks_file, col_types = readr::cols(.default="d", Features="c"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(readr::cols(.default="d", Features="c")))

What do the letters mean in this case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d refers to double and c refers to character. It is similar to the dtype options that pandas has for columns. R does a better job at handling data types more explicitly than python!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After dealing with the dtypes when trying to work with the .transpose function in python, I can see how convenient this is!

5_analyze_data/notebooks/KS-test_analysis/visualize_ks_test.py Outdated
# In[5]:


# Determine a bonferroni adjusted alpha value threshold
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use this to determine the threshold? Is there a reason or is this the standard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct! we need to adjust our alpha value for something called "multiple test correction". Bonferroni is the simplest and most straightfoward answer. Just divide 0.05 by the number of comparisons!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very simple! Good to know there are multiple ways of doing this also but this simple version seems to be the best option for this project.

5_analyze_data/notebooks/KS-test_analysis/visualize_ks_test.py Outdated
dplyr::filter(channel_cleaned == "actin") %>%
dplyr::select(Features)

top_actin_feature <- head(top_actin_feature, 1) %>% dplyr::pull(Features)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean to be a "top actin feature"? Is this the feature from the actin channel with the lowest p-value from the ks-test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep - you can see exactly what I'm doing to sort the values above, which will tell you what the top feature would represent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion at yesterday's meeting, this makes total sense!

@gwaybio
Copy link
Member Author

gwaybio commented Jan 19, 2023

Thanks for the review @jenna-tomkinson - I am going to merge!

@gwaybio gwaybio merged commit 95ecdb6 into WayScience:main Jan 19, 2023
@gwaybio gwaybio deleted the ks-test-viz branch January 19, 2023 00:26
d33bs added a commit to d33bs/NF1_SchwannCell_data that referenced this pull request Jan 31, 2023
@d33bs
Squashed commit of the following:
9405ef7 
commit fc76764
Merge: 0ba2392 d2b68b7
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Mon Jan 30 09:52:25 2023 -0700

    Merge pull request WayScience#38 from jenna-tomkinson/run_plates_with_cp_pipelines

    Run plates with cp pipelines

commit d2b68b7
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 27 12:56:42 2023 -0700

    edit documentation

commit 68e3ded
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 27 09:38:08 2023 -0700

    rerun plate 2 cellprofiler ic to confirm sc count

commit 62dadfa
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 27 09:19:10 2023 -0700

    fix issues wioth extract sc for plate2

commit b3bce04
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Jan 26 15:37:13 2023 -0700

    reorganize repo and run all plates in cp pipelines

commit 347c191
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 24 15:49:47 2023 -0700

    add documentation and converted notebooks

commit 6b917a4
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 24 13:25:07 2023 -0700

    run all plates with cellprofiler pipelines

commit a5221b0
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Jan 23 15:59:10 2023 -0700

    run plate 1 through cp

commit 0ba2392
Merge: 263a94c 310c12f
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Mon Jan 23 11:00:11 2023 -0700

    Merge pull request WayScience#35 from jenna-tomkinson/plate2_cellprofiler

    run plate 2 through cp and extract sc

commit 310c12f
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Jan 23 09:51:03 2023 -0700

    fix red error symbol issue

commit 9404554
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Jan 23 09:39:28 2023 -0700

    save optimized parameters for actin segmenation

commit ec6eb12
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Jan 23 09:18:30 2023 -0700

    run plate 2 through cp and extract sc

commit 263a94c
Merge: a90feed 933a4b1
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Fri Jan 20 12:00:19 2023 -0700

    Merge pull request WayScience#33 from jenna-tomkinson/plate2_illum_correction

    perform IC on plate 2

commit 933a4b1
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 20 11:22:14 2023 -0700

    perform IC on plate 2

commit a90feed
Author: Gregory Way <gregory.way@gmail.com>
Date:   Fri Jan 20 09:15:18 2023 -0700

    DP feature linear modeling and visualization (WayScience#31)

    * perform linear model with DP features

    * add DP visualization for linear model

    * add DP lm figure and small tweak to CP lm fig

    * remove extra empty cell

    * add DP cyto feature power analysis and viz

    * add title to CP power analysis viz

commit 62170be
Author: Gregory Way <gregory.way@gmail.com>
Date:   Fri Jan 20 08:43:01 2023 -0700

    Perform power analysis for CP features (WayScience#30)

    * perform power analysis

    * visualize power analysis

    * visualize top ER feature from KS test (outside scope of PR, sorry!)

    * fix variable name

commit 49fc39a
Author: Gregory Way <gregory.way@gmail.com>
Date:   Fri Jan 20 08:38:29 2023 -0700

    Create umap figure with ggplot (WayScience#29)

    * create umap figure with ggplot

    * add DP figure

commit 77ca026
Merge: 3a615f4 8da9f1c
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Thu Jan 19 15:36:30 2023 -0700

    Merge pull request WayScience#28 from jenna-tomkinson/nf1_dp_statistics

    DeepProfiler data stat analysis

commit 8da9f1c
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Jan 19 15:35:23 2023 -0700

    remove blank figures and edit code

commit 3a615f4
Author: Gregory Way <gregory.way@gmail.com>
Date:   Thu Jan 19 11:28:54 2023 -0700

    Create ComplexHeatmaps for Pilot Data plate 1 (WayScience#27)

    * add notebook to generate complexheatmaps

    * add complex heatmaps

    * add complexheatmap to env

    * save pngs too

    * add pngs and recreate pdfs

commit 0f2e400
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Jan 19 10:58:15 2023 -0700

    DeepProfiler data stat analysis (heatmap and umap)

commit 596e5f7
Author: Gregory Way <gregory.way@gmail.com>
Date:   Thu Jan 19 09:44:06 2023 -0700

    Add linear model analysis (WayScience#26)

    * add code to fit a linear model

    * add linear model results

    * add notebook to visualize linear model results

    * add pycytominer to analyze conda env

    * actually save the figure

    * update figure to show sign

    * remove red symbol

commit 95ecdb6
Author: Gregory Way <gregory.way@gmail.com>
Date:   Wed Jan 18 17:26:48 2023 -0700

    Visualizing the KS test results (WayScience#25)

    * add figure generaetion environment

    * add ks test visualizations

    * add visualization notebook for ks test results

    * get rid of red symbol EOF

    * nbconvert ipynb

    * nbconverting to r instead of python, good catch!

commit e71bb1f
Merge: 1ae36c3 3d18b66
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Wed Jan 18 08:55:10 2023 -0700

    Merge pull request WayScience#23 from jenna-tomkinson/nf1_dp_normalization

    deepprofiler project processing features

commit 3d18b66
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Jan 18 08:50:36 2023 -0700

    edits and update README

commit 46868d3
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 17 15:53:31 2023 -0700

    fix feature selection

commit 3137e54
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 17 15:33:49 2023 -0700

    deeprofiler project processing features

commit 1ae36c3
Merge: 8da88a4 a52b9c7
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Tue Jan 17 11:27:50 2023 -0700

    Merge pull request WayScience#22 from jenna-tomkinson/nf1_analysis

    heatmap and ks-test analysis

commit a52b9c7
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 17 11:27:14 2023 -0700

    edits and add figures

commit f758340
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 17 09:32:01 2023 -0700

    edits

commit ab68cb7
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 13 15:45:52 2023 -0700

    heatmap and ks-test analysis

commit 8da88a4
Merge: 610854c 283d170
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Wed Jan 11 11:05:31 2023 -0700

    Merge pull request WayScience#21 from jenna-tomkinson/nf1_statistics

    NF1 UMAP Stats

commit 283d170
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Jan 11 11:00:48 2023 -0700

    edit plot of number of sc

commit ec78e8c
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Jan 11 10:10:43 2023 -0700

    improved code to remove extra lines

commit 08bbb0f
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Jan 10 15:54:06 2023 -0700

    complete review edits

commit 74d1917
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Jan 9 15:19:21 2023 -0700

    UMAP notebooks and visualizations

commit 9adc2b4
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 6 15:43:45 2023 -0700

    add notebook for sc counts

commit 5782633
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Jan 6 15:41:31 2023 -0700

    start of NF1 statistics

commit 610854c
Merge: 1e70c20 b7bec10
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Wed Dec 14 14:13:53 2022 -0700

    Merge pull request WayScience#19 from jenna-tomkinson/add_new_dataset

    Add second NF1 dataset and correct the images

commit b7bec10
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Dec 14 14:08:04 2022 -0700

    fix barcode platemap

commit ab702df
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Dec 14 11:09:49 2022 -0700

    update .py file

commit 17fa768
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Wed Dec 14 11:06:52 2022 -0700

    update code and run second plate

commit 8d90300
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Dec 13 14:50:50 2022 -0700

    add updated dataset (from 12/12) and edit code

commit c6bf525
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Dec 12 15:54:05 2022 -0700

    updating code

commit ec3321c
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 16:50:49 2022 -0700

    update main README

commit a6b9987
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 16:49:38 2022 -0700

    update main README

commit a073b94
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 16:40:58 2022 -0700

    edits from review

commit 0d0b2cb
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 09:33:59 2022 -0700

    add black format to .py file

commit 23209b0
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 09:31:37 2022 -0700

    edit the documentation in the .py file

commit a3cb4b5
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 09:06:08 2022 -0700

    edit README

commit 6c878e5
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Fri Dec 9 08:56:38 2022 -0700

    edit README

commit 3a928d2
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Dec 8 18:08:13 2022 -0700

    edit notebook

commit da69b4e
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Dec 8 18:02:36 2022 -0700

    small edits to .py file

commit ed150bc
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Dec 8 18:01:48 2022 -0700

    corrected metadata and finished code

commit 8e855e0
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Thu Dec 8 17:44:04 2022 -0700

    update data and reordered the metadata

commit 6fd34de
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Tue Dec 6 14:27:31 2022 -0700

    add second plate

commit 1e70c20
Merge: 5536d86 861d71b
Author: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Date:   Mon Nov 28 13:06:10 2022 -0700

    Merge pull request WayScience#17 from jenna-tomkinson/edit_features_module

    Edit 4_processing_features module

commit 861d71b
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 28 13:04:49 2022 -0700

    edits

commit 1c8d46d
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 28 12:51:42 2022 -0700

    edits

commit be76e1b
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 28 12:50:06 2022 -0700

    edited documentation

commit cb7f39f
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 28 09:45:35 2022 -0700

    edited instructions and added file

commit 39f1bb0
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 14 14:32:25 2022 -0700

    correct metadata to rerun dp module

commit df7cedd
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 14 13:54:50 2022 -0700

    updated main README

commit 7c26bd6
Author: jenna-tomkinson <jenna.tomkinson@ucdenver.edu>
Date:   Mon Nov 14 13:51:13 2022 -0700

    edit data and create readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenna-tomkinson jenna-tomkinson jenna-tomkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwaybio @jenna-tomkinson