Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav links in markata.toml should be affected by start_url #135

Closed
pypeaday opened this issue Dec 28, 2022 · 2 comments
Closed

Nav links in markata.toml should be affected by start_url #135

pypeaday opened this issue Dec 28, 2022 · 2 comments

Comments

@pypeaday
Copy link
Collaborator

If start_url is set in markata.toml and a nav link is set as Home='/', what should happen is the nav link is rendered to point to /<start_url>, but this doesn't currently happen in markata~=0.6.0.dev0 (this is what I set in CI - I will get a real version later)
@WaylonWalker
Copy link
Owner

sounds legit, I am going to do this for only links not containing :// in case someone wants to hard link http:// https:// ftp:// ssh://

@WaylonWalker
Copy link
Owner

fixed in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WaylonWalker @pypeaday