Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo links to home page #54

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Logo links to home page #54

merged 3 commits into from
Apr 23, 2021

Conversation

kingdomlevel
Copy link
Contributor

  • Header logo converted to react-router-dom Link component
  • Header logo link now correctly targets home route
  • Footer app title text link converted to react-router-dom Link component
  • TODO added in the footer about adding the logo in here - I'll create a new issue about this in the github sprint project

@kingdomlevel kingdomlevel mentioned this pull request Apr 22, 2021
Closed
2 tasks
@yemijaiyeola yemijaiyeola merged commit a26396c into main Apr 23, 2021
@yemijaiyeola yemijaiyeola deleted the feature/logo-links-to-home-page branch April 25, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yemijaiyeola yemijaiyeola yemijaiyeola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingdomlevel @yemijaiyeola