Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed magic values in DESUtil #788

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fixed magic values in DESUtil #788

merged 1 commit into from
Jun 8, 2021

Conversation

jiaweifreshair
Copy link
Contributor

@jiaweifreshair jiaweifreshair commented Jun 6, 2021 •
edited
Loading

@jiaweifreshair jiaweifreshair changed the title 修复字符串没有常量化的问题 fixed magic values in DESUtil Jun 6, 2021
@jiaweifreshair jiaweifreshair marked this pull request as draft June 6, 2021 08:58
@jiaweifreshair jiaweifreshair marked this pull request as ready for review June 6, 2021 08:58
@jiaweifreshair jiaweifreshair marked this pull request as draft June 6, 2021 09:02
@jiaweifreshair jiaweifreshair marked this pull request as ready for review June 6, 2021 09:03
wushengyeyouya
wushengyeyouya approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@wushengyeyouya wushengyeyouya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wushengyeyouya wushengyeyouya merged commit 21ea2be into apache:dev-1.0.0 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wushengyeyouya wushengyeyouya wushengyeyouya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaweifreshair @wushengyeyouya