Remove unwind
#156
Merged
Remove unwind
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks people have generally agreed on removing `unwind` in the MVP spec, as it overlaps with `catch_all` in functionality. Fixes WebAssembly#153.
aheejin
requested review from
takikawa,
dschuff,
rossberg,
eqrion,
tlively and
lukewagner
tlively
approved these changes
Jun 3, 2021
Co-authored-by: Thomas Lively <7121787+tlively@users.noreply.github.com>
dschuff
approved these changes
Jun 3, 2021
|
(I've also invited Ross and Ioanna to the WebAssembly Github organization, which should allow them to be listed as reviewers on future PRs, and will also allow auto-completing their usernames 😄) |
takikawa
approved these changes
Jun 3, 2021
ioannad
approved these changes
Jun 3, 2021
ioannad
approved these changes
Jun 3, 2021
rossberg
approved these changes
Jun 8, 2021
ioannad
added a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 8, 2021
In particular:
- The labels surrounding try-catch and try-delegate now get a standard
label in the first step, which is then refined to catch-labels and/or
try-labels per subblock.
+ For that I allowed the new administrative instructions to appear
nested directly inside a label_n{} in block contexts.
+ Also added a validation rule to the administrative label_n{}.
+ Due to this, all block contexts appear now without a successor
exponent.
- Updated to latest try-catch syntax described in issue WebAssembly#157.
- Corrected some previously wrong syntax.
- Removed try-unwind (...) as per issue WebAssembly#156
- Updated Exceptions-formal-examples.md similarly.
pull bot
pushed a commit
to p-g-krish/v8
that referenced
this pull request
Jun 14, 2021
Relevant links: WebAssembly/exception-handling#153 WebAssembly/exception-handling#156 R=clemensb@chromium.org Bug: v8:8091 Change-Id: I0deeb9665c6648e643d0aa4f310b7676e1c2fa32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959624 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75135}
takikawa
added a commit
to takikawa/wasm-tools
that referenced
this pull request
Jun 14, 2021
This instruction was removed from the spec: WebAssembly/exception-handling#156
takikawa
added a commit
to takikawa/wasm-tools
that referenced
this pull request
Jun 14, 2021
This instruction was removed from the spec: WebAssembly/exception-handling#156
alexcrichton
pushed a commit
to bytecodealliance/wasm-tools
that referenced
this pull request
Jun 14, 2021
This instruction was removed from the spec: WebAssembly/exception-handling#156
Closed
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 22, 2021
This instruction was recently removed from the Wasm exception handling proposal spec: WebAssembly/exception-handling#156 Differential Revision: https://phabricator.services.mozilla.com/D118080
ioannad
added a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 25, 2021
In particular:
- The labels surrounding try-catch and try-delegate now get a standard
label in the first step, which is then refined to catch-labels and/or
try-labels per subblock.
+ For that I allowed the new administrative instructions to appear
nested directly inside a label_n{} in block contexts.
+ Also added a validation rule to the administrative label_n{}.
+ Due to this, all block contexts appear now without a successor
exponent.
- Updated to latest try-catch syntax described in issue WebAssembly#157.
- Corrected some previously wrong syntax.
- Removed try-unwind (...) as per issue WebAssembly#156
- Updated Exceptions-formal-examples.md similarly.
aheejin
added a commit
to aheejin/wabt
that referenced
this pull request
Jun 26, 2021
`unwind` was removed. See WebAssembly/exception-handling#156.
aheejin
added a commit
to WebAssembly/wabt
that referenced
this pull request
Jun 29, 2021
`unwind` was removed. See WebAssembly/exception-handling#156.
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jul 16, 2021
This instruction was recently removed from the Wasm exception handling proposal spec: WebAssembly/exception-handling#156 Differential Revision: https://phabricator.services.mozilla.com/D118080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks people have generally agreed on removing
unwindin the MVPspec, as it overlaps with
catch_allin functionality.Closes #153.
I tried to add all people as reviewers who participated in the relevant
previous discussions and #153. Not sure why these two usernames cannot
be added in the reviewers list: cc @RossTate @ioannad