Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] js-api tests getter on Boolean #133

Closed
xtuc opened this issue Feb 20, 2019 · 1 comment
Closed

[test] js-api tests getter on Boolean #133

xtuc opened this issue Feb 20, 2019 · 1 comment

Comments

@xtuc
Copy link
Contributor

xtuc commented Feb 20, 2019

This is already tracked in v8 but since it's duplicated here I'm posting it too.

According to https://tc39.github.io/ecma262/#sec-toboolean,

threads/test/js-api/memory/constructor.any.js

Line 133 in 0b80037

order.push("shared valueOf");
won't be called.
@xtuc
Copy link
Contributor Author

xtuc commented Feb 20, 2019

cc @binji @Ms2ger

Ms2ger added a commit to Ms2ger/threads that referenced this issue Feb 20, 2019
@Ms2ger
Improve tests for evaluation order.
a2797bd 
Fixes WebAssembly#133.
@Ms2ger Ms2ger mentioned this issue Feb 20, 2019
Merged
@xtuc xtuc mentioned this issue Feb 20, 2019
Merged
binji pushed a commit that referenced this issue Feb 20, 2019
@Ms2ger @binji
Improve tests for evaluation order. (#134)
e638ed4 
Fixes #133.
Hexcles pushed a commit to web-platform-tests/wpt that referenced this issue Feb 21, 2019
@Hexcles
fixup! Update constructor.any.js
a14b9ab 
Continuation of #15144, and for ref
[WebAssembly/threads#133](WebAssembly/threads#133).

Here's the corresponding CL in Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/1478791. I
guess the WPT bot had some trouble.

Change-Id: I1b3eee109ed951c7e9d7245bca7900c2e01799af
Bug: v8:8319
Reviewed-on: https://chromium-review.googlesource.com/c/1478791
Reviewed-by: Ben Smith [binji@chromium.org](mailto:binji@chromium.org)
Commit-Queue: Sven Sauleau [ssauleau@igalia.com](mailto:ssauleau@igalia.com)
Cr-Commit-Position: refs/heads/master@{#634108}
This was referenced Feb 21, 2019
Merged
Merged
Hexcles added a commit to web-platform-tests/wpt that referenced this issue Feb 21, 2019
@Hexcles
fixup! Update constructor.any.js (#15505)
6606d91 
(This is am empty commit to fix up the original PR #15480 
whose commit didn't have the Chromium footers expected
by Chromium wpt-importer.)

Continuation of #15144, and for ref
[WebAssembly/threads#133](WebAssembly/threads#133).

Here's the corresponding CL in Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/1478791. I
guess the WPT bot had some trouble.

Change-Id: I1b3eee109ed951c7e9d7245bca7900c2e01799af
Bug: v8:8319
Reviewed-on: https://chromium-review.googlesource.com/c/1478791
Reviewed-by: Ben Smith [binji@chromium.org](mailto:binji@chromium.org)
Commit-Queue: Sven Sauleau [ssauleau@igalia.com](mailto:ssauleau@igalia.com)
Cr-Commit-Position: refs/heads/master@{#634108}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xtuc