-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BiquadFilterNode seems underspecified #295
Comments
I did some work on that in the plane, you can look at it at http://padenot.github.io/web-audio-api/#filters-characteristics |
This looks really, really nice! The only thing I would add would be the formula for the transfer function. It makes the formulas clearer and pretty much does away with having to spell out the actual implementation algorithm since you already said the initial filter state is all zeroes. |
On Sat, Oct 25, 2014, at 04:36 AM, rtoy wrote:
Makes sense, yes. |
I should have clarified it looks great in FF, but not so much in Chrome which doesn't have mathml. I thought we were going to mathjax for this. |
This now looks good here on Chrome 38/Linux, sorry about that. |
Ah, beautiful. One last comment for now. I have not yet checked the formulas but the formulas use a plain alpha, but there is not definition for alpha. Presumably each function must be using of of the defined subscripted alpha variables. |
The description of the various types of biquad filter nodes seem underspecified. Even for the ones that have a wikipedia link seem unclear and some (lowshelf, highshelf, peaking) have no references at all.
Perhaps we should just add the formulas from Rick Lyons (?) page from which these filters were derived.
The text was updated successfully, but these errors were encountered: