Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioParam setter does not work after the execution of automation. #503

Closed
hoch opened this issue Mar 25, 2015 · 11 comments
Closed

AudioParam setter does not work after the execution of automation. #503

hoch opened this issue Mar 25, 2015 · 11 comments
Assignees
Labels
Needs Discussion The issue needs more discussion before it can be fixed. Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Milestone

Comments

@hoch
Copy link
Member

hoch commented Mar 25, 2015

This is something to think about - I don't think this behavior is clearly specified. What happens if the setter is used after cancelScheduledValues() method called?

var context = new AudioContext();
var sine = context.createOscillator();

sine.connect(context.destination);
sine.start();

sine.frequency.setValueAtTime(440.0, 0);
sine.frequency.linearRampToValueAtTime(880.0, 3);
sine.frequency.cancelScheduledValues(3.5);

var freq = 660.0;

function setValue() {
  freq = (freq === 660.0) ? 770.0 : 660.0;
  sine.frequency.value = freq;
  console.log('current time: ' + context.currentTime);  
  console.log('settting frequency: ' + freq);
  setTimeout(setValue, 2000);
}

setValue();

FYI, currently FF and Chromium don't do anything with the setter. Once the automation happens, it locks up the setter for good.

@notthetup
Copy link
Contributor

Hmm! I didn't know this. This might explain a few issues I was noticing with cancelling automation. Locking up the setter seems very unintuitive.

I would expecting a setter call, to internally cancel all automation and then set the value to the argument of the setter.

Otherwise it might make sense to somehow indicate that the setter is locked up after the automation starts.

@rtoy
Copy link
Member

rtoy commented Mar 26, 2015

Not all is lost, though. setValueAtTime still works and has the same effect as using the setter, except for the de-zippering that might happen. If de-zippering is needed you can use setTargetAtTime with an appropriate time constant.

I think the main issue is what happens to setTargetAtTime automations that are essentially infinite in duration. If it's already started, what does cancelScheduledEvents to with that? Or with any automation that has started but has not stopped yet?

@notthetup
Copy link
Contributor

@rtoy Good point.

I have gotten into a habit of doing this this every time I cancel any automation, because I wasn't sure what was actually happening. I know it's not perfect, but it works.

var currentVal = osc.frequency.value;
osc.frequency.cancelScheduledValues(context.currentTime);
osc.frequency.setValueAtTime(currentVal, context.currentTime);

@rtoy
Copy link
Member

rtoy commented Mar 26, 2015

Ah, this is a duplicate of issue #128

@hoch
Copy link
Member Author

hoch commented Apr 17, 2015

Just to leave a note about this issue, here's the excerpt from the section 2.5.3:

If the value attribute is set after any automation events have been scheduled, then these events will be removed.

So we remove all the existing events regardless of its start or end time. However, what happens after the removal of automation? De-zippering from the current intrinsic value to the setter value? (sounds a lot like setTargetAtTime() except that the de-zippering duration is fixed.)

We need to decide and specify the behavior for this case.

@mdjp mdjp modified the milestone: Uncommitted May 14, 2015
@joeberkovitz
Copy link
Contributor

Resolution: calling the setter implicitly invokes cancelScheduledValues(), which restores the operation of all further getter/setter calls. Clarify spec as needed.

@joeberkovitz joeberkovitz added the Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/ label Jun 1, 2015
@joeberkovitz joeberkovitz modified the milestones: Web Audio V1, Uncommitted Jun 1, 2015
@hoch hoch self-assigned this Jun 18, 2015
@hoch
Copy link
Member Author

hoch commented Aug 27, 2015

@rtoy, @cwilso and I discussed this issue a bit more in person, and we agreed that the last decision needs to be revisited.

  • Calling the setter should add a value-time point in the timeline with the current time. (= AudioParam.setValueAtTime(value, context.currentTime)) It should not cancel the scheduled automations.
  • cancelScheduledValues(t) should stop the automation at t and set a value-time point at t with a computed value of the previous automation at time t.

I guess we still have some open issues in AudioParam, and we should discuss them in the next F2F meeting.

@joeberkovitz joeberkovitz added the Needs Discussion The issue needs more discussion before it can be fixed. label Aug 27, 2015
@padenot
Copy link
Member

padenot commented Sep 23, 2015

I agree with @hoch, and I think this is something we need to discuss as the f2f indeed.

@joeberkovitz
Copy link
Contributor

Resolution: Merge PR 583, close this issue and #128 and file cancelScheduleValues(t) as a separate issue.

@hoch
Copy link
Member Author

hoch commented Sep 24, 2015

I will try to write up ideas/notes about cancelScheduleValues(t) and send it out to the group.

@hoch
Copy link
Member Author

hoch commented Sep 25, 2015

I did not need to open a new issue: we've already made a decision for cancelScheduledValues(t) at the issue #344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion The issue needs more discussion before it can be fixed. Needs Edits Decision has been made, the issue can be fixed. https://speced.github.io/spec-maintenance/about/
Projects
None yet
Development

No branches or pull requests

6 participants