-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AudioParam setter does not work after the execution of automation. #503
Comments
Hmm! I didn't know this. This might explain a few issues I was noticing with cancelling automation. Locking up the setter seems very unintuitive. I would expecting a setter call, to internally cancel all automation and then set the value to the argument of the setter. Otherwise it might make sense to somehow indicate that the setter is locked up after the automation starts. |
Not all is lost, though. setValueAtTime still works and has the same effect as using the setter, except for the de-zippering that might happen. If de-zippering is needed you can use setTargetAtTime with an appropriate time constant. I think the main issue is what happens to setTargetAtTime automations that are essentially infinite in duration. If it's already started, what does cancelScheduledEvents to with that? Or with any automation that has started but has not stopped yet? |
@rtoy Good point. I have gotten into a habit of doing this this every time I cancel any automation, because I wasn't sure what was actually happening. I know it's not perfect, but it works.
|
Ah, this is a duplicate of issue #128 |
Just to leave a note about this issue, here's the excerpt from the section 2.5.3:
So we remove all the existing events regardless of its start or end time. However, what happens after the removal of automation? De-zippering from the current intrinsic value to the setter value? (sounds a lot like We need to decide and specify the behavior for this case. |
Resolution: calling the setter implicitly invokes |
@rtoy, @cwilso and I discussed this issue a bit more in person, and we agreed that the last decision needs to be revisited.
I guess we still have some open issues in AudioParam, and we should discuss them in the next F2F meeting. |
I agree with @hoch, and I think this is something we need to discuss as the f2f indeed. |
Resolution: Merge PR 583, close this issue and #128 and file |
I will try to write up ideas/notes about |
I did not need to open a new issue: we've already made a decision for |
This is something to think about - I don't think this behavior is clearly specified. What happens if the setter is used after
cancelScheduledValues()
method called?FYI, currently FF and Chromium don't do anything with the setter. Once the automation happens, it locks up the setter for good.
The text was updated successfully, but these errors were encountered: