Fix delete row from repeatable group. Fixes #281 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuks
changed the title
|
Thank you! |
jtsternberg
added a commit
that referenced
this pull request
Jul 15, 2015
Fix delete row from repeatable group. Fixes #281
|
Oops, I just realized I merged your PR to the master branch which is our release branch. In the future, can you please submit PRs to the trunk branch? |
|
Sorry. Next time, will submit to the trunk branch. |
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this pull request
Jul 28, 2015
### Enhancements * Updated/Added many translations. Props [fxbenard](https://github.com/fxbenard), ([#203](CMB2/CMB2#344)) and [Mte90](https://github.com/Mte90) for the Italian translation. * Updated `'file_list'` field type to have a more intutive selection in the media library, and updated the 'Use file' text in the button. Props [SteveHoneyNZ](https://github.com/SteveHoneyNZ) ([#357](CMB2/CMB2#357), [#358](CMB2/CMB2#358)). * `'closed'` group field option parameter introduced in order to set the groups as collapsed by default. Requested in [#391](CMB2/CMB2#391). * Added `"cmb2_{$object_type}_process_fields_{$cmb_id}"` hook for hooking in and modifying the metabox or fields before the fields are processed/sanitized for saving. * Added Comment Metabox support. Props [GregLancaster71](https://github.com/GregLancaster71) ([#238](CMB2/CMB2#238), [#244](CMB2/CMB2#244)). * New "cmb2_{$field_id}_is_valid_img_ext" filter for determining if a field value has a valid image file-type extension. ### Bug Fixes * `'multicheck_inline'`, `'taxonomy_radio_inline'`, and `'taxonomy_multicheck_inline'` field types were not outputting anything since it's value was not being returned. Props [ediamin](https://github.com/ediamin), ([#367](CMB2/CMB2#367), ([#405](CMB2/CMB2#405)). * `'hidden'` type fields were not honoring the `'show_on_cb'` callback. Props [JPry](https://github.com/JPry), ([commits](CMB2/CMB2@5a4146e...1ef5ef1)). * Fixed: There was no minified cmb2-front.min.css file. * Fallback for fatal error with invalid timezone. Props [ryanduff](https://github.com/ryanduff) ([#385](CMB2/CMB2#385)). * Fix issues with deleting a row from repeatable group. Props [yuks](https://github.com/yuks) ([#387](CMB2/CMB2#387)). * Ensure value passed to `strtotime` in `make_valid_time_stamp` is cast to a string. Props [vajrasar](https://github.com/vajrasar) ([#389](CMB2/CMB2#389)). * Fixed issue with Windows IIS and bundling CMB2 in the theme. Props [DevinWalker](https://github.com/DevinWalker), ([#400](CMB2/CMB2#400), [#401](CMB2/CMB2#401)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1208582 b8457f37-d9ea-0310-8a92-e5e31aec5664
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this pull request
Jul 28, 2015
### Enhancements * Updated/Added many translations. Props [fxbenard](https://github.com/fxbenard), ([#203](CMB2/CMB2#344)) and [Mte90](https://github.com/Mte90) for the Italian translation. * Updated `'file_list'` field type to have a more intutive selection in the media library, and updated the 'Use file' text in the button. Props [SteveHoneyNZ](https://github.com/SteveHoneyNZ) ([#357](CMB2/CMB2#357), [#358](CMB2/CMB2#358)). * `'closed'` group field option parameter introduced in order to set the groups as collapsed by default. Requested in [#391](CMB2/CMB2#391). * Added `"cmb2_{$object_type}_process_fields_{$cmb_id}"` hook for hooking in and modifying the metabox or fields before the fields are processed/sanitized for saving. * Added Comment Metabox support. Props [GregLancaster71](https://github.com/GregLancaster71) ([#238](CMB2/CMB2#238), [#244](CMB2/CMB2#244)). * New "cmb2_{$field_id}_is_valid_img_ext" filter for determining if a field value has a valid image file-type extension. ### Bug Fixes * `'multicheck_inline'`, `'taxonomy_radio_inline'`, and `'taxonomy_multicheck_inline'` field types were not outputting anything since it's value was not being returned. Props [ediamin](https://github.com/ediamin), ([#367](CMB2/CMB2#367), ([#405](CMB2/CMB2#405)). * `'hidden'` type fields were not honoring the `'show_on_cb'` callback. Props [JPry](https://github.com/JPry), ([commits](CMB2/CMB2@5a4146e...1ef5ef1)). * Fixed: There was no minified cmb2-front.min.css file. * Fallback for fatal error with invalid timezone. Props [ryanduff](https://github.com/ryanduff) ([#385](CMB2/CMB2#385)). * Fix issues with deleting a row from repeatable group. Props [yuks](https://github.com/yuks) ([#387](CMB2/CMB2#387)). * Ensure value passed to `strtotime` in `make_valid_time_stamp` is cast to a string. Props [vajrasar](https://github.com/vajrasar) ([#389](CMB2/CMB2#389)). * Fixed issue with Windows IIS and bundling CMB2 in the theme. Props [DevinWalker](https://github.com/DevinWalker), ([#400](CMB2/CMB2#400), [#401](CMB2/CMB2#401)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1208586 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281 and #334