Skip to content

Commit

Permalink
http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.ht…
Browse files Browse the repository at this point in the history
…ml is failing

https://bugs.webkit.org/show_bug.cgi?id=239630
<rdar://92128154>

Reviewed by Youenn Fablet.

We get an error when closing the websocket. The error gets queued up on the event loop and
may or may not get processed before the test ends, leading to flakiness. The test is actually
about testing bufferedAmount after closing the socket and this part is still being tested and
reliably passing. As a result, I am simply silencing the error in the test to address the
flakiness.

* LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/249984@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Apr 26, 2022
1 parent 3fa50a3 commit 28c1703
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<!DOCTYPE html><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] -->
<html>
<head>
<script src="../../../../js-test-resources/js-test-pre.js"></script>
Expand Down Expand Up @@ -81,11 +81,6 @@
finishJSTest();
};

ws.onerror = function()
{
debug("Error.");
}

var messageToSend;
var bufferedAmountDifference;

Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/mac-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1442,9 +1442,6 @@ webkit.org/b/227639 [ BigSur Release ] fast/history/visited-href-mutation.html [
[ Monterey arm64 ] fast/animation/request-animation-frame-throttling-lowPowerMode.html [ Failure ]
[ Monterey arm64 ] fast/animation/css-animation-throttling-lowPowerMode.html [ Failure ]

# rdar://80342948 ([ Monterey wk2 ] http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html is a Flaky failure)
[ Monterey ] http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html [ Pass Failure ]

# Behavior of navigator-language-ru changed in Monterey
[ Monterey+ ] fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ]
[ BigSur ] fast/text/international/system-language/navigator-language/navigator-language-ru-2.html [ Failure ]
Expand Down

0 comments on commit 28c1703

Please sign in to comment.