Skip to content

Commit

Permalink
Merge r220681 - GTK-focused gardening.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

* http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
* http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
* media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
* platform/gtk/TestExpectations:
* platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
* platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.
  • Loading branch information
Ms2ger authored and carlosgcampos committed Aug 14, 2017
1 parent ee17dd6 commit 434e5f7
Show file tree
Hide file tree
Showing 9 changed files with 47 additions and 10 deletions.
16 changes: 16 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
2017-08-14 Ms2ger <Ms2ger@igalia.com>

GTK-focused gardening.
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

* http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
* http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
* media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
* platform/gtk/TestExpectations:
* platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
* platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.

2017-08-14 Ms2ger <Ms2ger@igalia.com>

[GTK] Update some test expectations.
Expand Down
Expand Up @@ -13,6 +13,7 @@
font-weight: bold;
list-style-type: lower-alpha;
font-variant-numeric: tabular-nums;
line-height: 30px;
}
</style>
</head>
Expand Down
Expand Up @@ -10,6 +10,7 @@
<style>
li {
list-style-type: lower-alpha;
line-height: 30px;
}

li::marker {
Expand Down
@@ -1,4 +1,4 @@
CONSOLE MESSAGE: Unhandled Promise Rejection: NotAllowedError (DOM Exception 35): The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
CONSOLE MESSAGE: Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
Test that "fullscreen requires user gesture restriction" is removed by a user gesture.

Click me!
Expand Down
12 changes: 7 additions & 5 deletions LayoutTests/platform/gtk/TestExpectations
Expand Up @@ -921,6 +921,7 @@ webkit.org/b/141467 fast/multicol/pagination/RightToLeft-rl-hittest.html [ Failu
webkit.org/b/141698 editing/pasteboard/5761530-1.html [ Failure ]
webkit.org/b/141699 fast/attachment/attachment-disabled-rendering.html [ Failure ]
webkit.org/b/141699 fast/attachment/attachment-rendering.html [ Failure ]
webkit.org/b/141699 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]

webkit.org/b/141705 media/video-fullscreeen-only-controls.html [ Failure ]

Expand Down Expand Up @@ -1199,7 +1200,7 @@ http/tests/ssl/applepay [ Skip ]
fast/scrolling/scrolling-tree-includes-frame.html [ Skip ]

# This test assumes that color on sliders is not reversed for RTL, so failing is good.
fast/forms/range/input-appearance-range-rtl.html [ Failure ]
fast/forms/range/input-appearance-range-rtl.html [ ImageOnlyFailure ]

# Service-workers implementation is not complete yet
webkit.org/b/175419 imported/w3c/web-platform-tests/service-workers/cache-storage [ Failure ]
Expand Down Expand Up @@ -1890,6 +1891,8 @@ webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Pass Fa
webkit.org/b/168373 media/video-multiple-concurrent-playback.html [ Failure Crash ]
webkit.org/b/168373 media/video-seek-past-end-paused.html [ Failure Pass ]

webkit.org/b/172255 imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html [ Pass Failure ]

webkit.org/b/174353 media/video-restricted-invisible-autoplay-not-allowed.html [ Crash Pass ]

webkit.org/b/174354 imported/w3c/IndexedDB-private-browsing/idbfactory_open.html [ Crash Pass ]
Expand Down Expand Up @@ -2220,8 +2223,7 @@ webkit.org/b/174242 media/media-fullscreen-pause-inline.html [ Timeout ]

webkit.org/b/174243 fast/images/low-memory-decode.html [ Timeout ]

webkit.org/b/174459 fast/images/async-image-background-image.html [ Timeout ]
webkit.org/b/174459 fast/images/async-image-body-background-image.html [ Timeout ]
webkit.org/b/174459 fast/images/async-image-body-background-image.html [ ImageOnlyFailure ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests timing out
Expand Down Expand Up @@ -3322,8 +3324,8 @@ webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-see
webkit.org/b/171726 imported/w3c/web-platform-tests/media-source/mediasource-seek-during-pending-seek.html [ Failure ]
webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure ]

webkit.org/b/171972 fast/images/async-image-background-image-repeated.html [ ImageOnlyFailure Timeout ]
webkit.org/b/171972 fast/images/sprite-sheet-image-draw.html [ ImageOnlyFailure Timeout ]
webkit.org/b/174459 fast/images/async-image-background-image-repeated.html [ ImageOnlyFailure ]
webkit.org/b/174459 fast/images/sprite-sheet-image-draw.html [ ImageOnlyFailure ]

webkit.org/b/172270 fast/text/font-interstitial-invisible-width-while-loading.html [ Failure ]
webkit.org/b/172270 fast/text/web-font-load-invisible-during-loading.html [ Failure ]
Expand Down
Expand Up @@ -18,7 +18,7 @@ PASS document.title is "null"

* domain attribute
PASS document.domain is "127.0.0.1"
PASS document.domain = null threw exception SecurityError: The operation is insecure..
PASS document.domain = null threw exception SecurityError: Attempted to use a non-registrable domain..
PASS document.domain is "127.0.0.1"
PASS successfullyParsed is true

Expand Down
@@ -0,0 +1,9 @@

PASS "toNativeLineEndings" should not be supported
FAIL "FileError" should not be supported assert_false: expected false got true
PASS "FileException" should not be supported
PASS Blob should not support slice prefixed
PASS BlobBuilder should not be supported.
PASS createFor method should not be supported
PASS Blob.close() should not be supported

Expand Up @@ -5,9 +5,9 @@ CONSOLE MESSAGE: line 27: Fetch API cannot load about:invalid.com. Cross origin
CONSOLE MESSAGE: line 27: Fetch API cannot load about:config. Cross origin requests are only supported for HTTP.
CONSOLE MESSAGE: line 27: Fetch API cannot load about:unicorn. Cross origin requests are only supported for HTTP.

FAIL Fetching about:blank (GET) is OK promise_test: Unhandled rejection with value: object "TypeError: Type error"
FAIL Fetching about:blank (PUT) is OK promise_test: Unhandled rejection with value: object "TypeError: Type error"
FAIL Fetching about:blank (POST) is OK promise_test: Unhandled rejection with value: object "TypeError: Type error"
FAIL Fetching about:blank (GET) is OK promise_test: Unhandled rejection with value: object "TypeError: Cross origin requests are only supported for HTTP."
FAIL Fetching about:blank (PUT) is OK promise_test: Unhandled rejection with value: object "TypeError: Preflight response is not successful"
FAIL Fetching about:blank (POST) is OK promise_test: Unhandled rejection with value: object "TypeError: Cross origin requests are only supported for HTTP."
PASS Fetching about:invalid.com is KO
PASS Fetching about:config is KO
PASS Fetching about:unicorn is KO
Expand Down
@@ -0,0 +1,8 @@

FAIL Fetching about:blank (GET) is OK promise_test: Unhandled rejection with value: object "TypeError: Cross origin requests are only supported for HTTP."
FAIL Fetching about:blank (PUT) is OK promise_test: Unhandled rejection with value: object "TypeError: The URL can’t be shown"
FAIL Fetching about:blank (POST) is OK promise_test: Unhandled rejection with value: object "TypeError: Cross origin requests are only supported for HTTP."
PASS Fetching about:invalid.com is KO
PASS Fetching about:config is KO
PASS Fetching about:unicorn is KO

0 comments on commit 434e5f7

Please sign in to comment.