Skip to content

Commit

Permalink
[Win][Clang] Remove -fmsc-version=1911 compiler switch
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263283

Reviewed by Don Olmstead.

190776@main (bug#173889) added -fmsc-version=1911 compiler switch for
clang-cl. However, it seems that it is no longer needed.

* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/269438@main
  • Loading branch information
fujii committed Oct 18, 2023
1 parent 7e993de commit a89b68f
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions Source/cmake/OptionsMSVC.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,6 @@ string(REPLACE "INCREMENTAL:YES" "INCREMENTAL:NO" replace_CMAKE_EXE_LINKER_FLAGS
set(CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO "${replace_CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO} /INCREMENTAL:NO")

if (COMPILER_IS_CLANG_CL)
# FIXME: The clang-cl visual studio integration seemed to set
# this to 1900 explicitly even when building in VS2017 with the
# newest toolset option, but we want to be versioned to match
# VS2017.
add_compile_options(-fmsc-version=1911)

# FIXME: Building with clang-cl seemed to fail with 128 bit int support
set(HAVE_INT128_T OFF)
list(REMOVE_ITEM _WEBKIT_CONFIG_FILE_VARIABLES HAVE_INT128_T)
Expand Down

0 comments on commit a89b68f

Please sign in to comment.