-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Some misc cleanup in new BBQ #10433
[JSC] Some misc cleanup in new BBQ #10433
Conversation
EWS run on previous version of this PR (hash 1a61345) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with suggestion.
@@ -8372,6 +8377,8 @@ class BBQJIT { | |||
RegisterSet m_callerSaves; | |||
|
|||
InternalFunction* m_compilation; | |||
|
|||
std::array<Vector<Jump>, numberOfExceptionTypes> m_exceptions { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use a JumpList
instead of a Vector<Jump>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, we should use JumpList. Changed.
1a61345
to
def1492
Compare
EWS run on previous version of this PR (hash def1492) |
def1492
to
796999f
Compare
https://bugs.webkit.org/show_bug.cgi?id=252654 rdar://105714823 Reviewed by Mark Lam. This patch does some cleanups in new BBQ. 1. Dedup exception throwing code. 2. Define FPRInfo::nonPreservedNonArgumentFPR0 and use it for m_scratchFPR. 3. Add boundary offset only when boundary is non-zero. * Source/JavaScriptCore/assembler/AbstractMacroAssembler.h: * Source/JavaScriptCore/jit/FPRInfo.h: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::BBQJIT): (JSC::Wasm::BBQJIT::addTableGet): (JSC::Wasm::BBQJIT::addTableSet): (JSC::Wasm::BBQJIT::addTableInit): (JSC::Wasm::BBQJIT::addTableFill): (JSC::Wasm::BBQJIT::addTableCopy): (JSC::Wasm::BBQJIT::emitCheckAndPreparePointer): (JSC::Wasm::BBQJIT::addMemoryFill): (JSC::Wasm::BBQJIT::addMemoryCopy): (JSC::Wasm::BBQJIT::addMemoryInit): (JSC::Wasm::BBQJIT::emitAtomicLoadOp): (JSC::Wasm::BBQJIT::emitAtomicStoreOp): (JSC::Wasm::BBQJIT::emitAtomicBinaryRMWOp): (JSC::Wasm::BBQJIT::emitAtomicCompareExchange): (JSC::Wasm::BBQJIT::atomicWait): (JSC::Wasm::BBQJIT::atomicNotify): (JSC::Wasm::BBQJIT::truncTrapping): (JSC::Wasm::BBQJIT::throwExceptionIf): (JSC::Wasm::BBQJIT::emitModOrDiv): (JSC::Wasm::BBQJIT::addRefAsNonNull): (JSC::Wasm::BBQJIT::endTopLevel): (JSC::Wasm::BBQJIT::addCallIndirect): (JSC::Wasm::BBQJIT::addExceptionLateLinkTask): Deleted. * Source/JavaScriptCore/wasm/WasmExceptionType.h: Canonical link: https://commits.webkit.org/260597@main
796999f
to
2a0f7a0
Compare
Committed 260597@main (2a0f7a0): https://commits.webkit.org/260597@main Reviewed commits have been landed. Closing PR #10433 and removing active labels. |
2a0f7a0
796999f
π wincairoπ§ͺ ios-wk2π§ͺ api-macπ§ͺ api-iosπ§ͺ mac-wk1π π§ͺ jscπ§ͺ mac-wk2π jsc-armv7π§ͺ mac-AS-debug-wk2π§ͺ jsc-armv7-testsπ§ͺ mac-wk2-stressπ§ͺ jsc-mips-tests