[JSC] Some misc cleanup in new BBQ #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 1a61345) |
MenloDorian
approved these changes
Feb 21, 2023
| @@ -8372,6 +8377,8 @@ class BBQJIT { | |||
| RegisterSet m_callerSaves; | |||
|
|
|||
| InternalFunction* m_compilation; | |||
|
|
|||
| std::array<Vector<Jump>, numberOfExceptionTypes> m_exceptions { }; | |||
There was a problem hiding this comment.
Why not just use a JumpList instead of a Vector<Jump>?
There was a problem hiding this comment.
Right, we should use JumpList. Changed.
Constellation
force-pushed
the
eng/JSC-Some-misc-cleanup-in-new-BBQ
branch
from
1a61345
to
def1492
Compare
|
EWS run on previous version of this PR (hash def1492) |
Constellation
force-pushed
the
eng/JSC-Some-misc-cleanup-in-new-BBQ
branch
from
def1492
to
796999f
Compare
|
EWS run on current version of this PR (hash 796999f) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=252654 rdar://105714823 Reviewed by Mark Lam. This patch does some cleanups in new BBQ. 1. Dedup exception throwing code. 2. Define FPRInfo::nonPreservedNonArgumentFPR0 and use it for m_scratchFPR. 3. Add boundary offset only when boundary is non-zero. * Source/JavaScriptCore/assembler/AbstractMacroAssembler.h: * Source/JavaScriptCore/jit/FPRInfo.h: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::BBQJIT): (JSC::Wasm::BBQJIT::addTableGet): (JSC::Wasm::BBQJIT::addTableSet): (JSC::Wasm::BBQJIT::addTableInit): (JSC::Wasm::BBQJIT::addTableFill): (JSC::Wasm::BBQJIT::addTableCopy): (JSC::Wasm::BBQJIT::emitCheckAndPreparePointer): (JSC::Wasm::BBQJIT::addMemoryFill): (JSC::Wasm::BBQJIT::addMemoryCopy): (JSC::Wasm::BBQJIT::addMemoryInit): (JSC::Wasm::BBQJIT::emitAtomicLoadOp): (JSC::Wasm::BBQJIT::emitAtomicStoreOp): (JSC::Wasm::BBQJIT::emitAtomicBinaryRMWOp): (JSC::Wasm::BBQJIT::emitAtomicCompareExchange): (JSC::Wasm::BBQJIT::atomicWait): (JSC::Wasm::BBQJIT::atomicNotify): (JSC::Wasm::BBQJIT::truncTrapping): (JSC::Wasm::BBQJIT::throwExceptionIf): (JSC::Wasm::BBQJIT::emitModOrDiv): (JSC::Wasm::BBQJIT::addRefAsNonNull): (JSC::Wasm::BBQJIT::endTopLevel): (JSC::Wasm::BBQJIT::addCallIndirect): (JSC::Wasm::BBQJIT::addExceptionLateLinkTask): Deleted. * Source/JavaScriptCore/wasm/WasmExceptionType.h: Canonical link: https://commits.webkit.org/260597@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Some-misc-cleanup-in-new-BBQ
branch
from
796999f
to
2a0f7a0
Compare
|
Committed 260597@main (2a0f7a0): https://commits.webkit.org/260597@main Reviewed commits have been landed. Closing PR #10433 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2a0f7a0
796999f
🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🛠 🧪 jsc🧪 mac-wk2🛠 jsc-armv7🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests🧪 mac-wk2-stress🧪 jsc-mips-tests